[HOLD for payment 2023-04-27] [$1000] Edited autolink with several underscores contains incorrect target URL

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open staging.new.expensify.com
2. Open chat and send a message
3. Edit the message and replace it with a URL with several underscores (Example : https://www.facebook.com/hashtag/__main/?__eep__=6 )

Expected Result:

Autolink URL from edited message should rendered as it is

Actual Result:

One of the underscores in the hyperlink target replaced with em and some parts of the hyperlink text is rendered as italic

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.88-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Link.Edit.2.mp4

Recording.34.mp4

Expensify/Expensify Issue URL:
Issue reported by: @kerupuksambel
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679633088263169

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0136dd0251d483d039
• Upwork Job ID: 1641797489981591552
• Last Price Increase: 2023-04-07

[MelvinBot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MitchExpensify]

Reproduced

[MitchExpensify]

This was reported last year and fixed here #13405

Reckon this is a regression @alex-mechler?

[alex-mechler]

Yeah, this looks like a good ole regression, or just a spot that was somehow missed in that pr.

I don't think yours is a reproduction though @MitchExpensify, none of that text is italic.

[MitchExpensify]

Oh lol, yes you are right @alex-mechler, silly me! Would a next step be to reopen that issue seeing as the regression originated there, close this, and compensate @kerupuksambel for catching it again?

[alex-mechler]

I would leave this one open, since it has been several months this counts as a new / different regression

[MitchExpensify]

@kerupuksambel I'm unable o reproduce the italics, I wonder if its something to do with how you are copying and pasting the link, mind trying typing it out?

[MitchExpensify]

[kerupuksambel]

@MitchExpensify Sure thing! Here's my URL string I used : https://www.facebook.com/hashtag/__main/?__eep__=6. However, please make sure you send the message as an edit instead of a new message, so the steps should be :

1. Send a sample message
2. Edit the message
3. Edit it to https://www.facebook.com/hashtag/__main/?__eep__=6
4. Save it and examine the resulted (edited) string

That way I still able to reproduce the error.