[HOLD for payment 2023-08-01] [$1000] Emojis inside the reaction buttons appear far down

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat
2. Add a reaction
3. Observe the emojis inside the buttons

Expected Result:

Should be properly aligned in the center

Actual Result:

Appears closer to bottom of the bottom

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.12
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683717352716409

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d57ef93d5d7af14e
• Upwork Job ID: 1656626923913682944
• Last Price Increase: 2023-06-01

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Emoji is not in center of reaction button

What is the root cause of that problem?

In

App/src/styles/StyleUtils.js

Lines 1040 to 1052 in 1d951e6

	function getEmojiReactionBubbleTextStyle(isContextMenu = false) {
	if (isContextMenu) {
	return {
	fontSize: 17,
	lineHeight: 28,
	};
	}
	return {
	fontSize: 15,
	lineHeight: 24,
	};
	}

if the fontSize is 15, the actual lineHeight of emoji is 20. But we're setting the lineHeight is 24
if the fontSize is 17, the actual lineHeight of emoji is 24. But we're setting the lineHeight is 28

=> That makes the emoji is not in center

What changes do you think we should make in order to solve the problem?

update the lineHeight of emoji accordingly:

if the fontSize is 15, set the lineHeight of emoji is 20.
if the fontSize is 17, set the lineHeight of emoji is 24.

we also add paddingVertical: 2 to keep the size is the same as before

function getEmojiReactionBubbleTextStyle(isContextMenu = false) {
    if (isContextMenu) {
        return {
            fontSize: 17,
            lineHeight: 24,
            paddingVertical: 2,
        };
    }

    return {
        fontSize: 15,
        lineHeight: 20,
        paddingVertical: 2,
    };
}

Result

IOS:

Screen.Recording.2023-05-11.at.17.09.38.mov

Web:

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d57ef93d5d7af14e

[melvin-bot]

Current assignee @muttmuure is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot]

Triggered auto assignment to @grgia (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.