[HOLD for payment 2023-06-02] [$1000] System throws a technical error message on clicking 'Message' link

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Sign in with account A (default contact method)
2. Add account B as a secondary login of account A
3. Sign in with account C on a new tab
4. Open a chat with account A
5. Mention secondary login account B
6. Send message
7. Switch tab to where account A is signed in
8. Open the message sent from account C
9. Click on the mentioned secondary login message
10. Verify a details sidebar displaying details of the secondary login account is displayed
11. Click on Message link
12. Observe that system has thrown a technical error message (Auth OpenReport returned an error)
    ~13. Click on the browser's refresh button
13. Observe that user is signed out~

Expected Result:

System shouldn't throw a technical error, and shouldn't sign out user

Actual Result:

System throws a technical error message, and signs out user

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.13
Reproducible in staging?: y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-05-11.15.10.47.mp4

Recording.582.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683807771824459

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b88f02a102ef7dee
• Upwork Job ID: 1660541944319033344
• Last Price Increase: 2023-05-22

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Natnael-Guchima]

Since the secondary login account is not treated as a separate account, I believe 'Message' link shouldn't be available on the details sidebar when clicking on the secondary login mention. Rather, the details sidebar for secondary login should have the same elements as the details sidebar for the default contact method.

[melvin-bot]

@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

System throws a technical error message on clicking 'Message' link

What is the root cause of that problem?

Currently we don't allow sending message to the same account (including all the accounts of contact methods), so when we try to message an account from our contact methods, server will return the errors.

What changes do you think we should make in order to solve the problem?

I agree with @Natnael-Guchima that we shouldn't show the Message button when we open the detail page of all the email from our contact methods.
In order to do that, we should update the condition to show or hide Message button inside DetailsPage.
Currently we only hide it when the mail equals the main contact method in here:

App/src/pages/DetailsPage.js

Lines 190 to 197 in 293f23b

	{details.login !== this.props.session.email && (
	<MenuItem
	title={`${this.props.translate('common.message')}${details.displayName}`}
	icon={Expensicons.ChatBubble}
	onPress={() => Report.navigateToAndOpenReport([details.login])}
	wrapperStyle={styles.breakAll}
	shouldShowRightIcon
	/>

So the condition to show the Message button will look like this:

 const isCurrentUser = _.keys(this.props.loginList).includes(details.login);

                                {!isCurrentUser && (
                                    <MenuItem
                                        title={`${this.props.translate('common.message')}${details.displayName}`}
                                        icon={Expensicons.ChatBubble}
                                        onPress={() => Report.navigateToAndOpenReport([details.login])}
                                        wrapperStyle={styles.breakAll}
                                        shouldShowRightIcon
                                    />
                                )}

What alternative solutions did you explore? (Optional)

None.

[mallenexpensify]

This is going to take a while to test, will get to soon

[melvin-bot]

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.