[HOLD for payment 2023-06-01] [$1000] Mentions results does not close when we change focus

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report
3. Add some text in beginning and add @ and type any letters to get mentions
4. shift focus to start of compose box and observe mentions results are still visible
5. Try same thing with emoji suggestion and observe that suggestions close when we shift focus

Expected Result:

App should close mention results on shifting focus like it does for emoji suggestions

Actual Result:

App does not close mention results on shifting focus

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.13-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

mention.does.not.close.on.focus.change.mp4

Recording.594.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683891760906869

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f6abecc2436476a9
• Upwork Job ID: 1658751456085680128
• Last Price Increase: 2023-05-17

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Mentions results does not close when we change focus

What is the root cause of that problem?

When text selection change, we call this method to calculate list mention suggestion

App/src/pages/home/report/ReportActionCompose.js

Lines 518 to 521 in 293f23b

	calculateMentionSuggestion() {
	if (this.state.selection.end < 1) {
	return;
	}

But it would be early exit if the current cursor (selection.end) is the first character.

What changes do you think we should make in order to solve the problem?

Remove this early exit check will solve the problem.

What alternative solutions did you explore? (Optional)

Instead of do nothing and early exit if the cursor is the first character, we can reset suggestedMentions state before exit. Almost same with what we are doing with emojis when the comment is empty

App/src/pages/home/report/ReportActionCompose.js

Lines 485 to 488 in 293f23b

	if (!this.state.value) {
	this.resetSuggestions();
	return;
	}

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Mentions results does not close when we change focus

What is the root cause of that problem?

We are checking if the current selection is smaller than 1 then early return here:

App/src/pages/home/report/ReportActionCompose.js

Lines 519 to 521 in 293f23b

	if (this.state.selection.end < 1) {
	return;
	}

When user moves cursor before "@" character, the selection end is now 0, so the suggestion mentions isn't re-calculated which caused this issue.

What changes do you think we should make in order to solve the problem?

In stead of early return here and do nothing, we should resetSuggestion then return:

         if (this.state.selection.end < 1) {
            this.resetSuggestions();
            return;
        }

What alternative solutions did you explore? (Optional)

[melvin-bot]

@bfitzexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[bfitzexpensify]

Reproduced.