[PAID] [$1000] recovery code cut from bottom

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. go to settings > Security > Two factor Authentication

Expected Result:

recovery code should not cut from bottom

Actual Result:

some recovery code font(like g, j) cut from bottom

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.18-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684822389953109

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bf08b4ce365db968
• Upwork Job ID: 1661828618471395328
• Last Price Increase: 2023-05-25

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

recovery code cut from bottom

What is the root cause of that problem?

We are setting the height of the Text in here which caused the issue

App/src/pages/settings/Security/TwoFactorAuth/CodesPage.js

Lines 85 to 88 in 4d6a25f

	_.map(props.account.recoveryCodes.split(', '), (code) => (
	<Text
	style={styles.twoFactorAuthCode}
	key={code}

App/src/styles/styles.js

Lines 2141 to 2146 in 4d6a25f

	twoFactorAuthCode: {
	fontFamily: fontFamily.MONOSPACE,
	width: 100,
	height: 18,
	textAlign: 'center',
	},

What changes do you think we should make in order to solve the problem?

Due to difference dimensions screens, that's bad idea to fix height for a text.
We should remove the height of the text, or remove the height with minHeight that will fix the issue:

    twoFactorAuthCode: {
        fontFamily: fontFamily.MONOSPACE,
        width: 100,
       minHeight: 18 // or we can remove it as well
       // height: 18,
        textAlign: 'center',
    },

What alternative solutions did you explore? (Optional)

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

recovery code text cuts from bottom

What is the root cause of that problem?

Default font size is 15 and the line height is 20, giving a height of 18px for the Text is the conflict and causing this issue.

What changes do you think we should make in order to solve the problem?

We can remove the height given to the text from here so it will take the required 20px default lineheight for the font size of 15px.

App/src/styles/styles.js

Line 2144 in 6c7d479

height: 18,

Or we can change the lineHeight to 18 for this and reduce the font-size which fit with the same line height, maybe 14px.

[strepanier03]

I'm able to recreate this easily on a test account on Android Native, sending on.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bf08b4ce365db968

[melvin-bot]

Current assignee @strepanier03 is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)