[HOLD for payment 2023-06-12] [$1000] App crashes after changing default contact method

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Precondition: You should have an account with more than one contact methods set up and should have a money request threads

Action Performed:

1. Go to settings > Profile > Contact method
2. Change the current default contact method
3. Open an IOU thread from the LHN
4. Click on the IOU card to open the thread
5. Go to settings > Profile > Contact method
6. Change the current default contact method to the previous one

Expected Result:

App should not crash

Actual Result:

App crashes

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.18-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-05-23.12.19.32.mp4

Recording.758.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684833850028879

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015600b3c5d6d8f7f3
• Upwork Job ID: 1661995758902030336
• Last Price Increase: 2023-05-26

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes after changing default contact method

What is the root cause of that problem?

When user changed the default contact methods, even the reportRecipient was undefined, shouldShowReportRecipientLocalTime returned true.

We are using difference email variable between ReportActionCompose and canShowReportRecipientLocalTime. When user changed their default contact method, sessionEmail got updated to new contact method email, mean while this.props.currentUserPersonalDetails.login was still the old email.

Problem came from the way we set our optimisticData when we changed default contact methods.

    const optimisticData = [
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: ONYXKEYS.SESSION,
            value: {
                email: newDefaultContactMethod,
            },
        },
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: ONYXKEYS.LOGIN_LIST,
            value: {
                [newDefaultContactMethod]: {
                    pendingFields: {
                        defaultLogin: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
                    },
                    errorFields: {
                        defaultLogin: null,
                    },
                },
            },
        },
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: ONYXKEYS.PERSONAL_DETAILS,
            value: {
                [newDefaultContactMethod]: {
                    ...myPersonalDetails,
                    login: newDefaultContactMethod,
                    displayName: PersonalDetails.getDisplayName(newDefaultContactMethod, myPersonalDetails),
                },
                [oldDefaultContactMethod]: null,
            },
        },
    ];

As we can see the optimisticData, we updated the session email first that will trigger the withCurrentUserPersonalDetails HOC.

App/src/components/withCurrentUserPersonalDetails.js

Lines 39 to 41 in ec9bc04

	const currentUserEmail = props.session.email;
	const accountID = props.session.accountID;
	const currentUserPersonalDetails = useMemo(() => ({...props.personalDetails[currentUserEmail], accountID}), [props.personalDetails, currentUserEmail, accountID]);

While the email session is new email, the new contact methods email detail is NOT added to the ONYXKEYS.PERSONAL_DETAILS yet, that will make props.personalDetails[currentUserEmail] return undefined, that's why we can see 2 difference emails from ReportActionCompose and canShowReportRecipientLocalTime have difference values.

What changes do you think we should make in order to solve the problem?

We should use the same email to calculate the reportParticipants inside ReportActionCompomse and canShowReportRecipientLocalTime. Let say that we should use sessionEmail.

// Report Action Compose
 const reportParticipants = _.without(lodashGet(this.props.report, 'participants', []), this.props.sessionEmail);

We also should use lodashGet to get user name inside ParticipantLocalTime

const reportRecipientDisplayName = lodashGet(this.props, "participant.firstName") || lodashGet(this.props, "participant.displayName")

What alternative solutions did you explore? (Optional)

N/A

[greg-schroeder]

Reviewing

[greg-schroeder]

Hmm - I reproduced the crash on step 2 of the reproduction steps. @Natnael-Guchima @kavimuru - are the IOU steps required for reproduction?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015600b3c5d6d8f7f3

[melvin-bot]

Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)