[HOLD for payment 2023-07-10] [$1000] Web- Chat - Unable to leave the Concierge "Welcome Message" thread

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Sign in with a new account
2. Go to the Concierge chat
3. Hover over the welcome message from Concierge
4. Click on Reply in thread icon
5. Click on thread header
6. Click on Leave thread

Note: this only occurs on the Welcome message

Expected Result:

Thread is no longer there on LHN

Actual Result:

Thread is still there on LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.24-4

Reproducible in staging?: yes

*Reproducible in production?: n/a

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-29.at.8.47.50.PM.mov

Expensify/Expensify Issue URL:

Issue reported by: @adeel0202

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685376970661379

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0168a95ee497fd9964
• Upwork Job ID: 1665923109054201856
• Last Price Increase: 2023-06-06

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unable to leave the thread that was created with Concierge

What is the root cause of that problem?

When leaving chat we will navigate to Conciege Chat as default

App/src/libs/actions/Report.js

Line 1667 in 9fa12f3

navigateToConciergeChat();

But in here

App/src/libs/actions/Report.js

Lines 769 to 771 in 9fa12f3

	if (ReportUtils.isConciergeChatReport(report)) {
	conciergeChatReportID = report.reportID;
	}

Both the main Concierge chat and thread chat with Concierge will be assigned to conciergeChatReportID

So that when leaving the thread with Conciegre, the App will re-direct again to this chat

What changes do you think we should make in order to solve the problem?

Because isConciergeChatReport function is used in many places. So I suggest we should add one param called includeThreadWithConcierge in this function for more flexibility in the future like this

function isConciergeChatReport(report, includeThreadWithConcierge = false) {
    return lodashGet(report, 'participants', []).length === 1 && report.participants[0] === CONST.EMAIL.CONCIERGE && (includeThreadWithConcierge || !isThread(report))
}

And then we will update all places that use this function and this is my suggestion, maybe we need to confirm more

1. And in here:

   App/src/libs/actions/Report.js

   Lines 769 to 771 in 9fa12f3

   	if (ReportUtils.isConciergeChatReport(report)) {
   	conciergeChatReportID = report.reportID;
   	}

   
   we should pass includeThreadWithConcierge === false

2. In here:
   

   App/src/libs/ReportUtils.js

   Lines 750 to 753 in b8d4576

   	if (isConciergeChatReport(report)) {
   	result.source = CONST.CONCIERGE_ICON_URL;
   	return [result];
   	}

   
   we should pass includeThreadWithConcierge === true

3. In here:
   

   App/src/libs/SidebarUtils.js

   Line 105 in b8d4576

   const conciergeChatReport = _.find(allReports, ReportUtils.isConciergeChatReport);

   
   we should pass includeThreadWithConcierge === false (default value)

4. In here
   

   App/src/pages/home/report/ContextMenu/ContextMenuActions.js

   Line 304 in b8d4576

   !ReportUtils.isConciergeChatReport(reportID) &&

   
   we should pass includeThreadWithConcierge === true

5. In here
   

   App/src/pages/home/ReportScreen.js

   Line 289 in b8d4576

   {Boolean(this.props.accountManagerReportID) && ReportUtils.isConciergeChatReport(this.props.report) && this.state.isBannerVisible && (

   
   we should pass includeThreadWithConcierge === false

### What alternative solutions did you explore? (Optional)

After leaving the child thread, we can navigate to parent chat instead of Concierge chat. if do that we can pass parentReportID to

App/src/libs/actions/Report.js

Line 1638 in 9fa12f3

function leaveRoom(reportID) {

and in here

App/src/libs/actions/Report.js

Line 1667 in 9fa12f3

navigateToConciergeChat();

navigate to parent chat instead of conciege chat

Or we can remove navigate function in leaveRoom function and navigate to parent chat in here

App/src/pages/ReportDetailsPage.js

Line 116 in 9fa12f3

action: () => Report.leaveRoom(props.report.reportID),

like this

action: () => {
                    Report.leaveRoom(this.props.report.reportID)
                    Navigation.navigate(ROUTES.getReportRoute(this.props.report.parentReportID));
                },

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[jliexpensify]

We're on staging v1.3.24-4, please re-test on the newest version.

I am not seeing this issue on my end.

[esh-g]

@jliexpensify I'm still able to reproduce on staging v1.3.24-4

Cool.mov

[esh-g]

Proposal

posted in slack 5 days ago

Please re-state the problem that we are trying to solve in this issue

Unable to leave the thread that was created with Concierge

What is the root cause of that problem?

App/src/libs/actions/Report.js

Lines 761 to 772 in edf9b18

	function handleReportChanged(report) {
	if (!report || ReportUtils.isIOUReport(report)) {
	return;
	}
	if (report && report.reportID) {
	allReports[report.reportID] = report;
	if (ReportUtils.isConciergeChatReport(report)) {
	conciergeChatReportID = report.reportID;
	}
	}

In Report.js we are updating conciergeChatReportID in the handleReportChanged function and when we create a new thread from concierge chat, this gets updated to the chat thread instead of the actual concierge report. Therefore, when we exit the thread, it tries to direct the user to what it thinks is concierge chat but actually is the chat that we left.

What changes do you think we should make in order to solve the problem?

Before updating conciergeChatReportID, we are checking if it is concierge by the ReportUtils.isConciergeChatReport() method

App/src/libs/ReportUtils.js

Lines 376 to 378 in edf9b18

	function isConciergeChatReport(report) {
	return lodashGet(report, 'participants', []).length === 1 && report.participants[0] === CONST.EMAIL.CONCIERGE;
	}

So, we need to add an additional condition to this method report.parentReportID === null . So we can use the function isThread(report) to do that as well. This will make sure that we don't set a thread of concierge as the conciergeChatReportID and this successfully eliminates this issue.

Complete implementation

function isConciergeChatReport(report) {
    return lodashGet(report, 'participants', []).length === 1 && report.participants[0] === CONST.EMAIL.CONCIERGE && !isThread(report);
}

What alternative solutions did you explore? (Optional)

[jliexpensify]

Thanks @esh-g for testing - so I misunderstood the original issue and tested on a standard thread in Concierge, which works as normal.

I can repro the behaviour with the Concierge auto-message, but I would also say an additional issue is that Concierge is duplicating the exact same message in-thread (when you leave it):