[HOLD for payment 2023-07-06] [$1000] iOS - Thread - LHN is cut if swipe away from thread and chat

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #19185

Action Performed:

1. Open iOS app on a real device
2. Open a chat
3. Long press a message in chat that doesn't have a thread
4. Tap "Reply in thread"
5. Swipe thread screen to the right to close it and land in chat
6. Swipe chat screen to the right to close it and land in LHN
7. Repeat steps 2-6 if you cannot initially reproduce

Expected Result:

LHN is displayed screen-wide without any issues

Actual Result:

There is an empty space at the bottom of the LHN after swiping from the thread

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.26.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6086634_IMG_7883.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01558dcf5b3e274d73
• Upwork Job ID: 1668283079090876416
• Last Price Increase: 2023-06-12

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[amyevans]

• I'm able to reproduce both when swiping back and using the back button, on my physical iPhone on version 1.3.26.0
• I'm unable to reproduce this on a simulator on main
• I'm unable to build locally to my physical iPhone to further test/debug:

error:Failed to prepare the device for development. This operation can fail if the version of the OS on the device is incompatible with the installed version of Xcode. You may also need to restart your Mac and device in order to correctly detect compatibility.

As next steps I'll try to resolve that Xcode error and also take a look through the PRs on staging to see if something sticks out.

cc @mountiny in case you have any initial thoughts. It feels like it could still be related to the navigation refactor, though I'm not positive.

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[situchan]

Navigation refactor is already on production so should not be related.

[amyevans]

I got my local build issues sorted 🎉 , will continue to look for the PR causing the issue

[amyevans]

Ok I feel like I'm going a little bit insane with this one (in that I'll test against a commit once and not be able to repro the bug, then test again later and it's reproducible, so I start to question if I can trust my testing or if I need to "start over", or what exactly is going on).

But I decided to take a step back and install the production app and retest there, and I am able to reproduce the bug:

20514-repro.mov

So I think at the least this isn't a Deploy Blocker (cc @roryabraham curious if you agree). It doesn't happen the first time doing the action, but on any subsequent repeats of the action it does. Video 2 after a fresh sign in:

20514-repro-2.mov

[amyevans]

I also confirmed on main that it doesn't happen on the first time swiping but does on subsequent, so that is consistent with production. I'm going to go ahead and remove the DeployBlockerCash label.

@mountiny / @WoLewicki, on Monday would y'all mind taking a look at this one to determine if it's indeed related to the navigation refactor? 🙇‍♀️