[HOLD for payment 2023-06-30] [$1000] Offline message is not positioned correctly for disable two-factor authentication

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to ND
2. Navigate to settings -> navigate to security
3. Navigate to Two-factor authentication (add authentication if not added)
4. After enabling ->turn off the internet (go to offline state)
5. Navigate to settings -> navigate to security -> Navigate to Two-factor authentication

Expected Result:

Offline message should be displayed at bottom of the page same as other pages

Actual Result:

Offline message not displayed at bottom

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.29.3

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @dhairyasenjaliya

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686539484519239

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c99d947a115cd586
• Upwork Job ID: 1671078418775011328
• Last Price Increase: 2023-06-20

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Offline message is not positioned correctly for disable two-factor authentication

What is the root cause of that problem?

The root cause we have missed out to add flex property to view that makes contact not to take full height of screen

What changes do you think we should make in order to solve the problem?

There are multiple ways to resolve this issue

Solution 1

We can simply wrap IsEnabledPage.js -> <Section> to <ScrollView> which has flex property that will adjust content to screen height

Solution 2

We can simply wrap IsEnabledPage.js -> <Section> to <View flex:1> that will adjust content to screen height

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Offline message is not positioned correctly for disable two-factor authentication

What is the root cause of that problem?

We are not allowing the Section content to take full available height which is causing the issue.

What changes do you think we should make in order to solve the problem?

Add styles.flex1 to the only page Section containerStyles here which will grow to the available height.

App/src/pages/settings/Security/TwoFactorAuth/IsEnabledPage.js

Line 40 in f1b37bb

containerStyles={[styles.twoFactorAuthSection]}

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c99d947a115cd586

[melvin-bot]

Current assignee @dylanexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)