[HOLD for payment 2023-07-10] [$1000] Assign task show error when creating within a report

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open chat with any user
2. Click + in compose
3. Assign task
4. Input the title
5. Next => Observe the error appearing: "There was an error assigning this task, please try another assignee."

Expected Result:

Error message doesn't appear
and there should not be an empty avatar in the task assignee view

Actual Result:

Observe the error appearing: "There was an error assigning this task, please try another assignee."

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.31-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-21.at.11.10.48.mov

Expensify/Expensify Issue URL:
Issue reported by: @Victor-Nyagudi
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687320876332399

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0152a7fadbf2438272
• Upwork Job ID: 1672104067929206784
• Last Price Increase: 2023-06-23

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[namhihi237]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The error message doesn't appear when at new open modal up

What is the root cause of that problem?

When creating a task from the report, it will automatically assign based on the report.

App/src/pages/tasks/NewTaskPage.js

Lines 75 to 93 in 6183609

	useEffect(() => {
	setErrorMessage('');
	// If we have an assignee, we want to set the assignee data
	// If there's an issue with the assignee chosen, we want to notify the user
	if (props.task.assignee) {
	const assigneeDetails = lodashGet(OptionsListUtils.getPersonalDetailsForAccountIDs([props.task.assigneeAccountID], props.personalDetails), props.task.assigneeAccountID);
	if (!assigneeDetails) {
	return setErrorMessage(props.translate('newTaskPage.assigneeError'));
	}
	const displayDetails = TaskUtils.getAssignee(assigneeDetails);
	setAssignee(displayDetails);
	}
	// If we don't have an assignee and we are creating a task from a report
	// this allows us to auto assign a participant of the report.
	if (!props.task.assignee && props.task.parentReportID) {
	TaskUtils.setAssigneeValueWithParentReportID(props.task.parentReportID);
	}

App/src/libs/actions/Task.js

Lines 456 to 467 in 6183609

	function setAssigneeValueWithParentReportID(reportID) {
	const report = ReportUtils.getReport(reportID);
	const isDefault = !(ReportUtils.isChatRoom(report) || ReportUtils.isPolicyExpenseChat(report));
	const participants = lodashGet(report, 'participants', []);
	const hasMultipleParticipants = participants.length > 1;
	if (!isDefault || hasMultipleParticipants || report.parentReportID) {
	return;
	}
	Onyx.merge(ONYXKEYS.TASK, {assignee: participants[0]});
	}

The problem lies in this function, we have only set assignee, so when running on the if (props.task.assignee) condition, the assigneeAccountID has not been set. so assigneeDetails = null => show error

const assigneeDetails = lodashGet(OptionsListUtils.getPersonalDetailsForAccountIDs([props.task.assigneeAccountID], props.personalDetails), props.task.assigneeAccountID);

What changes do you think we should make in order to solve the problem?

Create a task within a report, It will default share in the room, but will not set an assignee by default => so we will remove code here:

App/src/pages/tasks/NewTaskPage.js

Lines 89 to 94 in 6183609

	// If we don't have an assignee and we are creating a task from a report
	// this allows us to auto assign a participant of the report.
	if (!props.task.assignee && props.task.parentReportID) {
	TaskUtils.setAssigneeValueWithParentReportID(props.task.parentReportID);
	}

Result:

Screen.Recording.2023-06-27.at.01.01.43.mov

What alternative solutions did you explore? (Optional)

N/A

[sakluger]

Reproduced, cc @thienlnam in case you want to work on this one.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0152a7fadbf2438272

[melvin-bot]

Current assignee @sakluger is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)