[HOLD for payment 2023-07-21] [$1000] Web - Bank - Back icon on last stage of adding bank account page is not clickable in offline mode

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Settings > Workspace > Bank account
3. Enter bank account manually using the following information
   Routing Number: 011401533
   Account Number: 1111222233331111
   Company: Alberta Bobbeth Charleson
   Tax ID: 123456789
   First Name: Alberta
   Last Name: Charleson
   (put anything in the other fields, but don't add any beneficial owner, not even yourself)
4. At the final step (Submit three amounts), close the side pane.
5. Disconnect internet
6. Go to Settings > Workspace > Bank account
7. Click on the back icon

Expected Result:

User is able to return to workspace settinggs

Actual Result:

Back icon is not clickable

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.34.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6110070_bandicam_2023-06-29_03-33-09-417.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a97e625eb340b983
• Upwork Job ID: 1674741547786518528
• Last Price Increase: 2023-07-07

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Nikhil-Vats]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clicking back icon on last stage of adding bank account page in offline mode doesn't navigate anywhere or close RHN.

What is the root cause of that problem?

When we are on final step but not done then achData state has the value PENDING. So, when we click back shouldShowContinueSetupButton is changed to true.

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js

Lines 306 to 315 in 9fc9f79

	case CONST.BANK_ACCOUNT.STEP.VALIDATION:
	if (_.contains([BankAccount.STATE.VERIFYING, BankAccount.STATE.SETUP], achData.state)) {
	BankAccounts.goToWithdrawalAccountSetupStep(CONST.BANK_ACCOUNT.STEP.ACH_CONTRACT);
	} else if (achData.state === BankAccount.STATE.PENDING) {
	this.setState({
	shouldShowContinueSetupButton: true,
	});
	} else {
	Navigation.goBack();
	}

So, ContinueBankAccountSetup should be shown but it is not shown because the condition in if block above it is true and so ReimbursementAccountLoadingIndicator keeps on returning and we get stuck on the same step.

The condition in first if block is true because ACH data is still loading shouldShowOfflineLoader is true since we are in offline mode but not in one of the steps listed on line 337. So, we never go to the second if block to render ContinueBankAccountSetup.

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js

Lines 334 to 360 in 9fc9f79

	// Prevent the full-page blocking offline view from being displayed for these steps if the device goes offline.
	const shouldShowOfflineLoader = !(
	this.props.network.isOffline &&
	_.contains([CONST.BANK_ACCOUNT.STEP.BANK_ACCOUNT, CONST.BANK_ACCOUNT.STEP.COMPANY, CONST.BANK_ACCOUNT.STEP.REQUESTOR, CONST.BANK_ACCOUNT.STEP.ACH_CONTRACT], currentStep)
	);
	// Show loading indicator when page is first time being opened and props.reimbursementAccount yet to be loaded from the server
	// or when data is being loaded. Don't show the loading indicator if we're offline and restarted the bank account setup process
	if ((!this.state.hasACHDataBeenLoaded || isLoading) && shouldShowOfflineLoader) {
	const isSubmittingVerificationsData = _.contains([CONST.BANK_ACCOUNT.STEP.COMPANY, CONST.BANK_ACCOUNT.STEP.REQUESTOR, CONST.BANK_ACCOUNT.STEP.ACH_CONTRACT], currentStep);
	return (
	<ReimbursementAccountLoadingIndicator
	isSubmittingVerificationsData={isSubmittingVerificationsData}
	onBackButtonPress={this.goBack}
	/>
	);
	}
	if (this.state.shouldShowContinueSetupButton) {
	return (
	<ContinueBankAccountSetup
	reimbursementAccount={this.props.reimbursementAccount}
	continue={this.continue}
	policyName={policyName}
	/>
	);
	}

What changes do you think we should make in order to solve the problem?

We should just change the order of if blocks so that if shouldShowContinueSetupButton is true then we return it rather than being stuck in ReimbursementAccountLoadingIndicator in offline mode.

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a97e625eb340b983

[melvin-bot]

Current assignee @flaviadefaria is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[allroundexperts]

Thanks for your proposal @Nikhil-Vats. Changing the order of the screen will cause the Continue Bank Account Setup screen to show up first even if the user is offline. After applying the changes that you suggested, when I first open the 'Connect Bank Account' screen, here is how it looks:
https://github.com/Expensify/App/assets/30054992/1ec46256-ad12-422c-b9a4-320fee228647

I'm not sure if we want to modify current behaviour in favour of showing Continue bank account setup screen. Can you update your proposal such that other user flows remain intact?

If you feel like that we should show Continue bank account setup screen first, then I'd suggest to gather some opinions in the open-source channel.