[HOLD for payment 2023-07-26] [$1000] Web - Wrong information is shown if we create a group with descending order for the names of the users

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging dot on web chrome
2. Click on FAB icon and click on new group
3. (Important step), Select two users but in the descending order of the first letter of their email. (For example if you have two users with an email example@gmail.com and applauseemail@gmail.com), you need to first select the example@gmail.com and then finally you need to select the applauseemail@gmail.com, so that you select the users in the descending order of the first character of their emails.
4. Create a group
5. You can see a welcome message 'This is the beginning of...."
6. Click on both the users email present on the above welcome message and notice that user details are wrong. Both details gets exchanged.

Expected Result:

Correct details should be shown if we create a group in descending order for the email of the users

Actual Result:

Wrong information is shown if we create a group with descending order for the emails of the users

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.35-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

error-2023-07-02_12.04.57.mp4

Recording.3380.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688278732228069

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015a2987433c41d846
• Upwork Job ID: 1677068596844310528
• Last Price Increase: 2023-07-06

[eh2077]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Wrong information is shown if we create a group with descending order for the names of the users.

What is the root cause of that problem?

The array displayNamesWithTooltips

App/src/components/ReportWelcomeText.js

Lines 59 to 62 in b0add94

	const displayNamesWithTooltips = ReportUtils.getDisplayNamesWithTooltips(
	OptionsListUtils.getPersonalDetailsForAccountIDs(participantAccountIDs, props.personalDetails),
	isMultipleParticipant,
	);

is created from object

App/src/components/ReportWelcomeText.js

Line 60 in b0add94

OptionsListUtils.getPersonalDetailsForAccountIDs(participantAccountIDs, props.personalDetails),

So the root cause of this issue is that participantAccountIDs[index] is possibly not match with displayNamesWithTooltips[index].accountID

App/src/components/ReportWelcomeText.js

Lines 98 to 107 in b0add94

	{_.map(displayNamesWithTooltips, ({displayName, pronouns, accountID}, index) => (
	<Text key={`${displayName}${pronouns}${index}`}>
	<UserDetailsTooltip accountID={accountID}>
	<Text
	style={[styles.textStrong]}
	onPress={() => {
	const accountDetails = props.personalDetails[participantAccountIDs[index]];
	if (accountDetails && accountDetails.accountID) {
	Navigation.navigate(ROUTES.getProfileRoute(accountDetails.accountID));
	}

, which navigates to wrong profile page.

What changes do you think we should make in order to solve the problem?

To fix this issue, we should use the accountID from displayNamesWithTooltips. We can change

App/src/components/ReportWelcomeText.js

Lines 103 to 108 in b0add94

	onPress={() => {
	const accountDetails = props.personalDetails[participantAccountIDs[index]];
	if (accountDetails && accountDetails.accountID) {
	Navigation.navigate(ROUTES.getProfileRoute(accountDetails.accountID));
	}
	}}

to

onPress={() => Navigation.navigate(ROUTES.getProfileRoute(accountID))}

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[esh-g]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Wrong information is shown if we create a group with descending order for the names of the users.

What is the root cause of that problem?

In this code:

App/src/components/ReportWelcomeText.js

Lines 102 to 108 in 84301c9

	style={[styles.textStrong]}
	onPress={() => {
	const accountDetails = props.personalDetails[participantAccountIDs[index]];
	if (accountDetails && accountDetails.accountID) {
	Navigation.navigate(ROUTES.getProfileRoute(accountDetails.accountID));
	}
	}}

We are getting the account details from by using the map index from participantAccountIDs. But participantAccountIDs array is not sorted in accordance with the displayNamesWithTooltips array which causes this discrepancy.

What changes do you think we should make in order to solve the problem?

We should get the account details from the correct account ID. For that we can change line 104 to the following:

const accountDetails = props.personalDetails[accountID];

It is important that we change this line and not line 106 because if the accountDetails for the first account exist and for the second account doesn't, we will still be able to navigate to the account ID even if accountDetails don't exist.

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

@sonialiap Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[sonialiap]

Triaging to external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015a2987433c41d846