[HOLD for payment 2023-09-27] [$1000] Web - RHP overlapping with the popovers

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login with any account and open any chat.
2. Click on the avatar in the chat header to open the chat details RHP.
3. Click anywhere else to close it.
4. Press the video call icon in the chat header to open the popover.
5. Press the forward button in the browser.

Expected Result:

RHP should open and popover should close.

Actual Result:

Both RHP and popover are open.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.41-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-15.at.1.38.43.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: Sibtain Ali
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689367096915129

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013464e806f5099ea9
• Upwork Job ID: 1696143850157252608
• Last Price Increase: 2023-09-04

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ahmdshrif]

Proposal

Please restate the problem that we are trying to solve in this issue.

The video chat menu does not hide when RHP is open.

What is the root cause of that problem?

We are not checking if the screen is focused on the VideoChatMenuActive and hiding it accordingly.

What changes do you think we should make in order to solve the problem?

We will need to determine if the screen is focused or not using the withNavigationFocus HOC or useNavigationFocus hook. Then, we can create a hook to trigger when isFocused changes. If the screen is not focused, we will hide the menu. The code can be implemented as shown below:

const propTypes = {
    ...
    ...withNavigationFocusPropTypes,
};

...

useEffect(() => {
    if (props.isFocused) {
        return;
    }
    setIsVideoChatMenuActive(false);
}, [props.isFocused]);

...

export default compose(withWindowDimensions, withLocalize, withNavigationFocus)(BaseVideoChatButtonAndMenu);

What alternative solutions did you explore? (Optional)

Another alternative solution is to use useNavigation change and check if the current route is not our route. If it's not our route, we can hide the call menu.

[allroundexperts]

I think this should be held on #15289.

[NicMendonca]

still holding