[HOLD for payment 2023-10-09] [HOLD for payment 2023-09-27] [Tracking] Improve ReportScreen re-renders

[mountiny]

Problem

The Report screen has a lot of performance bottlenecks. Mostly they are caused by unnecessary re-renders and given this component is very heavy to render, it can visibly slow down the App.

Solution

This is a tracking issue for multiple PRs and improvements which are found.

We are analysing the render cycles via Flipper Profiler and React Dev Tools and finding where are the bottle necks in the rendering of the component and its sub-tree.

So far we have found bugs regarding shared context and misuse of hooks that cause unnecessary re-renders. It might be an issue of death by a thousand paper cuts where seemingly innocuous changes cause large tree re-renders.

• [HOLD for payment 2023-09-29] Disable hover effect while scrolling in Report Screen on Web #27214

PRs:

• Create REPORT_METADATA onyx key to separate report loading logic from the report data #26173
• Use initialValue in withOnyx and other optimizations for ReportScreen #26772
• Update Onyx to use a map for Onyx collection keys  #27130
• Add initialValue, delayUpdates to allow components to eagerly render. react-native-onyx#329

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010777a443667dee8f
• Upwork Job ID: 1696166898891616256
• Last Price Increase: 2023-08-28

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010777a443667dee8f

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @ntdiary (Internal)

[ospfranco]

Assign me :)