[HOLD for payment 2023-10-09] [$1000] Sign in- Language preference doesn't persist when user Signs in with google

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to sign in page
2. Change the browsers language preference to Spanish
3. Refresh Sign up page
4. Click on 'Sign in with Google icon'
5. Select your account & proceed to sign in

Expected Result:

Language preference should persist to the app

Actual Result:

Language preference reverts back to English

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.57-5

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.2023-08-22.07-38-27.mp4

bandicam.2023-08-29.00-20-27-406.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Natnael-Guchima

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692679468017399

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d5f71b81bcb185b1
• Upwork Job ID: 1696624990261616640
• Last Price Increase: 2023-08-29
• Automatic offers:
• aimane-chnaif | Reviewer | 26496302
• hoangzinh | Contributor | 26496303
• Natnael-guchima | Reporter | 26496305

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Sign in- Language preference doesn't persist when user Signs in with google

What is the root cause of that problem?

In the action method called to Sign in with Google, we haven't passed the current preferredLocale when call API yet

App/src/libs/actions/Session/index.js

Lines 256 to 259 in d84006f

	function beginGoogleSignIn(token) {
	const {optimisticData, successData, failureData} = signInAttemptState();
	API.write('SignInWithGoogle', {token}, {optimisticData, successData, failureData});
	}

That's reason the preferred locale is reset to default locale on BE side.

What changes do you think we should make in order to solve the problem?

1. FE: In the action method called to Sign in with Google above, we need to pass current preferredLocale when call API, same as login with email method

   App/src/libs/actions/Session/index.js

   Line 441 in d84006f

   preferredLocale,

2. BE: need to update so that it will pick preferredLocale param in API request, then process it like login with email method.

We can fix for Sign in with Apple as well.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d5f71b81bcb185b1

[melvin-bot]

Current assignee @isabelastisser is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[melvin-bot]

@isabelastisser, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!