[HOLD for payment 2024-07-30][Simplified Collect] Workspaces - Display picture/Avatar isn't shown in Workspace share Code page

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. go settings -> workspaces -> new workspace
2. Now click the display avatar -> edit photo -> upload photo
3. Notice that the uploaded photo is displayed.
4. Now go to #announce or #admin or workspace chat of the same newly created workspace.
5. go to details page.
6. Notice that there is 'expensify' symbol in QR code. i.e display picture of corresponding workspace isn't shown.

Expected Result:

display picture of corresponding workspace should be shown in share code page.

Actual Result:

display picture of corresponding workspace isn't shown in share code page for workspace.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.68-15

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-09.at.5.06.41.PM.mov

Recording.1518.mp4

Expensify/Expensify Issue URL:

Issue reported by: @ashimsharma10

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694259150016599

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f242a32573a62742
• Upwork Job ID: 1701685406614237184
• Last Price Increase: 2023-10-03

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f242a32573a62742

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @garrettmknight (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue

Display picture of corresponding workspace should be shown in share code page.

What is the root cause of that problem?

We do not pass the image for such cases.

What changes do you think we should make in order to solve the problem?

Using ReportUtils.getIcons we can receive an image and then pass it to the code in ShareCodePage

https://github.com/Expensify/App/blob/3fe7ab1c7d860f40eeb9a52b911f8d7bc4781dd5/src/pages/ShareCodePage.js

        const reportIcon = ReportUtils.getIcons(this.props.report, this.props.personalDetails, this.props.policies);
        const reportLogo = typeof reportIcon[0].source === 'string' ? reportIcon[0].source : expensifyLogo;

And then pass in QRShareWithDownload

App/src/pages/ShareCodePage.js

Lines 65 to 73 in 3fe7ab1

	<QRShareWithDownload
	ref={this.qrCodeRef}
	url={url}
	title={isReport ? this.props.report.reportName : this.props.currentUserPersonalDetails.displayName}
	subtitle={isReport ? subtitle : formattedEmail}
	logo={isReport ? expensifyLogo : UserUtils.getAvatarUrl(this.props.currentUserPersonalDetails.avatar, this.props.currentUserPersonalDetails.accountID)}
	logoRatio={isReport ? CONST.QR.EXPENSIFY_LOGO_SIZE_RATIO : CONST.QR.DEFAULT_LOGO_SIZE_RATIO}
	logoMarginRatio={isReport ? CONST.QR.EXPENSIFY_LOGO_MARGIN_RATIO : CONST.QR.DEFAULT_LOGO_MARGIN_RATIO}
	/>

like
logo={isReport ? reportLogo : UserUtils.getAvatarUrl(this.props.currentUserPersonalDetails.avatar, this.props.currentUserPersonalDetails.accountID)}

Screen.Recording.2023-09-12.at.22.21.45.mov

What alternative solutions did you explore? (Optional)

NA