[$500] Web - App takes user two steps back after clicking on browser back button from Year page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Profile -> Personal Details -> Date of birth -> Year
2. Click on the browser back button

Expected Result:

App should take user to the date of birth page

Actual Result:

App takes user two steps back to the Personal Details page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.70.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.4496.mp4

2023-09-14.14.43.04.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694691923038999

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01991ba5bf527a5951
• Upwork Job ID: 1703744307185139712
• Last Price Increase: 2023-09-18
• Automatic offers:
• b4s36t4 | Contributor | 27665448
• ishpaul777 | Contributor | 28064011

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01991ba5bf527a5951

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @alexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[b4s36t4]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - App takes user two steps back after clicking on browser back button from Year page

What is the root cause of that problem?

Basically year selector is a modal on which we don't have any navigation. So for browser or react-navigation the route we're in date-of-birth.

When we click on browser back button it's taking the previous route related to date-of-birth route.

What changes do you think we should make in order to solve the problem?

So as far as I see it's the expected behavior because the YearSelector is a modal

But we show the modal as full-screen element which previews like it's another screen.

1. We can make the YearSelector as route and give it a push/pop state we can make browser back button work as expected.

2. We can make the YearSelector to show it's a modal (a bit complicated in my view and need design review as well).

In my view making this as route is plausible solution.

Updates required

1. Removing the Component Rendering

   App/src/components/NewDatePicker/CalendarPicker/index.js

   Line 237 in db4d85b

   <YearPickerModal

2. App/src/components/NewDatePicker/CalendarPicker/index.js

   Line 138 in db4d85b

   onPress={() => this.setState({isYearPickerVisible: true})}

   Update this line to Push the route instead of updating the state.

3. Use Onyx to mutating the state. The calendar right now is managing everything in state. But to workout with Year, we can use Onyx and have a key like userDOBYear or something which would provide the way to read the selected year inside this component

   App/src/components/NewDatePicker/CalendarPicker/index.js

   Line 42 in db4d85b

   class CalendarPicker extends React.PureComponent {

   .

4. App/src/components/NewDatePicker/CalendarPicker/index.js

   Line 80 in db4d85b

   onYearSelected(year) {

   Make this function which handles year change to support the onyx key change. Like componentDidUpdate if the year got updated we run this function.

Basically running every reference making sure Onyx keys are updated and glued together to make the YearModal as a route and support value coupling.

We should also fix the same issues with other modals like StateSelector modal's etc. I feel we can raise multiple PRs to eliminate regressions.

What alternative solutions did you explore? (Optional)

NA