[HOLD for payment 2023-10-10] Web - Private note - Private notes closed when clicking save button after refreshing the page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the website
2. Open any group chat from LHN if there is a group chat and then go to step 7. If there is no group chat, go to Step 3
3. Click the + icon from LHN
4. Click Send message
5. Add users by clicking Add to group
6. Click Create group
7. Click the header from the group chat and open detail RHN
8. Click on the user from the group members
9. Click Private notes
10. Click my notes
11. Click Notes
12. Add some value and Click save
13. Do step 11 again
14. Reload the page
15. Click the save button
16. Observe the result

Expected Result:

When clicking save the value should be saved and goes to Notes RHN

Actual Result:

When clicking the save button the RHN gets closed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.72-10
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screenshare.-.2023-09-20.1_41_48.PM.1.mp4

bandicam.2023-09-22.17-46-20-788.mp4

Expensify/Expensify Issue URL:
Issue reported by: @misgana96
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695206404845639

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017083ab1bb282119f
• Upwork Job ID: 1705205888707555328
• Last Price Increase: 2023-09-22
• Automatic offers:
• ntdiary | Reviewer | 26881269
• BhuvaneshPatil | Contributor | 26881270
• misgana96 | Reporter | 26881274

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017083ab1bb282119f

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[BhuvaneshPatil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Private note - Private notes closed when clicking save button after refreshing the page

What is the root cause of that problem?

After refreshing, the navigation stack clears, and we go default HOME route

App/src/pages/PrivateNotes/PrivateNotesEditPage.js

Line 94 in 7bebfd3

Navigation.goBack(ROUTES.HOME);

What changes do you think we should make in order to solve the problem?

HOME routes is being used as fallback here, we can use
getPrivateNotesViewRoute function to get the route.and use instead of ROUTES.HOME.
account ID can be grabbed using - route.params.accountID

What alternative solutions did you explore? (Optional)

Also I want to point out about other pages,
After refresh, when we save the note and got notes list page. Upon clicking on back button in header, we are taken to HOME route.
The reason being same, after refresh the stack is cleared.
For fixing this we need to tweak the HeaderWithBackButton and provide new prop, fallbackRoute
And assign it default value as ROUTES.HOME.
And modify the onBackButtonPress method.

The new prop will be the string which takes user back to expected route.