[HOLD for payment 2023-11-09] [$500] Web - New Dot Showing Console Error's when Creating New Policy from OldDot

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open up OldDot and login with Email1.
2. Hover over settings > open policies.
3. Now in new tab open NewDot.
4. Login with Email2.
5. Now from Old Dot press "New Policy".
6. Verify that on navigating Console Error's are appearing and Also the other New Tab shows error with other Console Error's.

Expected Result:

No Console Error Should be logged in either of the tabs of NewDot.

Actual Result:

Console Error's are logged for both the tabs of NewDot.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.71.4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

OldDot-Console.1.mp4

Recording.1647.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @jeet-dhandha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695429296097429

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c3a1c9a063a200e2
• Upwork Job ID: 1706660570183720960
• Last Price Increase: 2023-10-10
• Automatic offers:
• jeet-dhandha | Contributor | 27300211
• jeet-dhandha | Reporter | 27300215

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c3a1c9a063a200e2

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[MrJithil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

While a different users signed in OldDot and NewDot, once a user clicks on the New Free Policy, a new tab will navigate the user to the NewDot with OldDot user login. It is creating console log errors.

What is the root cause of that problem?

Since the users are different, the api is returning empty onyxData for a couple of requests. This is not being passing through a null check.

What changes do you think we should make in order to solve the problem?

Currently we are calling the updateHandler(onyxData) for all api responses. Before each update, we are only checking the onyxData is false or not.

The updateHandler is accepting input parameter as an array. So, we only pass the onyxData to the updateHandler if it has at least an item.

So, we need a check like onyxData && onyxData.length ? call update handler : default resolver

This change will be a single line change where we need to add the length check.
To comply with the code standards, we can make use of optional chain mechanism too. Ie,
onyxData?.length ? call update handler : default resolver

The same changes will need in updating the successData, failureData as well to avoid any future console errors.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[MrJithil]

Updated the proposals with successData and failureData error handlers.

[jeet-dhandha]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Console error on NewDot, while creating new policy from OldDot.

What is the root cause of that problem?

• Below all places uses UserUtils.getDefaultAvatar function, which return's a SVG instead of default avatar URL.

App/src/libs/ReportUtils.js

Line 2248 in cfad43f

avatar: lodashGet(currentUserPersonalDetails, 'avatar', UserUtils.getDefaultAvatar(currentUserAccountID)),

App/src/libs/ReportUtils.js

Line 2287 in cfad43f

avatar: lodashGet(currentUserPersonalDetails, 'avatar', UserUtils.getDefaultAvatar(currentUserAccountID)),

App/src/libs/ReportUtils.js

Line 2361 in cfad43f

avatar: lodashGet(currentUserPersonalDetails, 'avatar', UserUtils.getDefaultAvatar(currentUserAccountID)),

App/src/libs/ReportUtils.js

Line 2435 in cfad43f

avatar: lodashGet(currentUserPersonalDetails, 'avatar', UserUtils.getDefaultAvatar(currentUserAccountID)),

App/src/libs/ReportUtils.js

Line 2552 in cfad43f

avatar: lodashGet(allPersonalDetails, [currentUserAccountID, 'avatar'], UserUtils.getDefaultAvatar(currentUserAccountID)),

App/src/libs/ReportUtils.js

Line 2591 in cfad43f

avatar: lodashGet(allPersonalDetails, [currentUserAccountID, 'avatar'], UserUtils.getDefaultAvatar(currentUserAccountID)),

App/src/libs/ReportUtils.js

Line 2610 in cfad43f

avatar: lodashGet(allPersonalDetails, [currentUserAccountID, 'avatar'], UserUtils.getDefaultAvatar(currentUserAccountID)),

• The default URL is used here.
  

  App/src/libs/ReportUtils.js

  Line 1923 in cfad43f

  avatar: lodashGet(allPersonalDetails, [currentUserAccountID, 'avatar'], UserUtils.getDefaultAvatarURL(currentUserAccountID)),

What changes do you think we should make in order to solve the problem?

• We can use UserUtils.getDefaultAvatarURL function, which return's a default avatar URL instead of SVG.

• Another Change for the openOnAdminRoom's console error which is coming in below before video.

• PR which caused above issue https://github.com/Expensify/App/pull/16581/files

App/src/libs/Navigation/AppNavigator/Navigators/CentralPaneNavigator.js

Line 21 in cec77d2

initialParams={{openOnAdminRoom: openOnAdminRoom ? 'true' : undefined}}

-initialParams={{openOnAdminRoom: openOnAdminRoom ? 'true' : undefined}}
+initialParams={{openOnAdminRoom: openOnAdminRoom === 'true' || undefined}}

Before Fix

BeforeFix.mp4

After Fix

AfterFix.mp4

What alternative solutions did you explore? (Optional)

• N/A

[kadiealexander]

@mollfpr please take a look!