[$500] Request - Unable to request money after a refresh

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on FAB > Request money > Scan
2. Upload a receipt > Choose a user
3. Refresh the page
4. Click on the Request Button

Expected Result:

Able to request money after the refresh

Actual Result:

Unable to request money after the refresh

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Build: v1.3.74-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

XRecorder_27092023_070354.mp4

T151mac.Request.Money-1.mp4

Screen_Recording_20230927_115408_Chrome.mp4

Recording.4775.mp4

Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695786807078109

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0178e49860d663e0a4
• Upwork Job ID: 1709206608423825408
• Last Price Increase: 2023-10-03

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[AndrewGable]

Able to reproduce on staging, not on production

[AndrewGable]

@luacmartins @danieldoglas -Reverting #27224 fixes the issue, it seems to be on this line:

https://github.com/Expensify/App/blob/main/src/pages/iou/steps/MoneyRequestConfirmPage.js#L222

Uncaught (in promise) TypeError: Cannot set properties of undefined (setting 'state')
    at eval (MoneyRequestConfirmPage.js:153:1)

[AndrewGable]

Going to let @luacmartins decide if he wants to CP a fix or CP a revert here, happy to help but don't want to spin up a revert if we want to move this forward.

[luacmartins]

I don't think this is a blocker. Although you can proceed with the flow on prod, the request also fails with 405 invalid amount because the local blob receipt file is gone after the refresh. Additionally, I think we already fixed it on main since I'm getting redirected back to the receipt selector page upon refresh. Trying to find where we fixed it though to be sure.

[luacmartins]

I'm not really sure what changed, but I'm always hitting this code on main and being navigated back to the receipt selector.

I'm gonna demote this to NAB since the request also fails on prod (on a different line but same root cause). I'll verify that this is resolved on staging after the next deploy.