[HOLD for payment 2023-10-13] Request money - Merchant scan error is not below the merchant field

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #27735

Action Performed:

Pre-requisite: user must be logged in and set up a Smartscan where merchant is missing

1. Open chat where Smartscan request was shared
2. Open the Smartscan report

Expected Result:

Error message for missing merchant should be below de merchant field

Actual Result:

Error message is shown on the right side of the field

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.75-0

Reproducible in staging?: Yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6219143_1695998739769.bandicam_2023-09-28_20-18-52-712.mp4

Bug6219143_1695998739771.Dppb6467_1_.mp4

Bug6219143_1695998739852.Ukey1890_1_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01789730632c97595a
• Upwork Job ID: 1708992647321452544
• Last Price Increase: 2023-10-02

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Merchant scan error has a inconsistent position.

What is the root cause of that problem?

We're supplying the error as a subtitle here.

What changes do you think we should make in order to solve the problem?

We should supply the error to the error prop of the MenuItemWithTopDescription instead of subtitle like we're doing here.

What alternative solutions did you explore? (Optional)

We can also make the error show up as subtitle instead everywhere.

[mountiny]

cc @Gonals coming from your PR I believe, you might want to handle this internally #27735

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01789730632c97595a

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

[jliexpensify]

Not overdue, waiting on Alberto.