[$500] Chat - Join thread appears even if user is already joined

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat
2. Hover on the message and click on reply in thread option
3. Dend any message in thread
4. Click on three dots and select leave thread option
5. Again go to same thread
6. Click on three dots

Expected Result:

It should show leave thread option

Actual Result:

Join thread option appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.75-2
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1695988719.MP4

RPReplay_Final1695988652.MP4

Screen_Recording_20230928_185342_Chrome.mp4

Screen.Recording.2023-09-28.at.6.50.02.PM.mov

Screen.Recording.2023-09-28.at.6.47.44.PM.mov

Screen_Recording_20230929_111133_New.Expensify.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695907051686469

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01dabd7bc44f3cd7c6
• Upwork Job ID: 1707777132631470080
• Last Price Increase: 2023-09-29

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01dabd7bc44f3cd7c6

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Join thread option appears after we've already joined a thread.

What is the root cause of that problem?

This condition returns true after a thread is left, which causes the Join option to show up.

What changes do you think we should make in order to solve the problem?

We should remove the condition here and show Join thread only if the report state is SUBMITTED and report status is CLOSED.

What alternative solutions did you explore? (Optional)

Alternatively, we can also hide the Join thread option if report state is open.

[allroundexperts]

By the way, this is related to #27748

[abdel-h66]

It looks like a normal behaviour, after leaving a thread, You don't want to receive notifications, and then the second click on the thread will not be considered as joining, it's more like previewing the thread. If you performed an extra step, like clicking on another chat for example, the thread will not stick on the LHN.

[puneetlath]

I agree, this seems like expected behavior to me.

I'm going to close this, but cc @srikarparsi @chiragsalian just in case I'm mistaken.