[PAID] [$500] LHN - Incorrect backup avatar while waiting for avatar to load

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app from a fresh sign in
2. Observe your own avatar in the top right of the LHN area

Expected Result:

I would expect this avatar to either use our fallback avatar image, or just be a solid icon fill circle like the rest of the loading avatars on the page

Actual Result:

The app displayed one of our default avatars while waiting for the correct avatar to load

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.76-0

Reproducible in staging?: Yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

2023-10-02.1.28.20.PM.1.mov

Expensify/Expensify Issue URL:

Issue reported by: @shawnborton

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696240585729759

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fb65a5e1b63a2756
• Upwork Job ID: 1718973678534291456
• Last Price Increase: 2023-10-30
• Automatic offers:
• dukenv0307 | Contributor | 27439507

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrect backup avatar while waiting for avatar to load

What is the root cause of that problem?

We pass the fallbackIcon as the default avatar of the user here to display if the data is loading

App/src/pages/home/sidebar/PressableAvatarWithIndicator.js

Line 55 in 05aa0c3

fallbackIcon={currentUserPersonalDetails.fallbackIcon}

What changes do you think we should make in order to solve the problem?

In PressableAvatarWithIndicator we can subscribe isLoading from Onyx with key ONYXKEYS.IS_LOADING_APP. And pass this to AvatarWithIndicator

App/src/pages/home/sidebar/PressableAvatarWithIndicator.js

Line 65 in c81a509

export default withCurrentUserPersonalDetails(PressableAvatarWithIndicator);

And in AvatarWithIndicator we will only display the View with background color themColors.skeletonLHNIn

<View style={[styles.sidebarAvatar, props.isLoading && {backgroundColor: themeColors.skeletonLHNIn}]}>
    {!props.isLoading && (
        <>
            <Avatar
                source={UserUtils.getSmallSizeAvatar(props.source)}
                fallbackIcon={props.fallbackIcon}
            />
            <Indicator />
        </>
    )}
</View>

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01702f576387e8afe4

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (External)

[strepanier03]

Able to repro:

[strepanier03]

All good to move forward. This was reported by one of our designers so they'd be the experts in expected behavior.

[ArekChr]

@strepanier03 Having a preview(thumbnail) image in base64 from the backend would be awesome as a fallback image.