[$500] Clicking on "New Workspace" in WS list closes the RHP for a brief moment and then opens the new workspace settings

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.84-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697303051407209

Action Performed:

1. Navigate for workspace list page.
2. Click on "New Workspace".

Expected Result:

New Workspace settings page opens without closing of RHP,

Actual Result:

Clicking on "New Workspace" in WS list closes the RHP for a brief moment and then opens the new workspace settings

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Screen.Recording.2023-10-16.at.4.01.48.AM.mov

Android: mWeb Chrome

a402e59c-419c-4e4d-9f1d-c41073ac1e6d.MP4

iOS: Native

RPReplay_Final1697408920.MP4

iOS: mWeb Safari

RPReplay_Final1697408981.MP4

MacOS: Chrome / Safari

Screen.Recording.2023-10-14.at.10.32.26.PM.mov

clicking.on.New.Workspace.in.WS.list.closes.the.RHP.for.a.brief.moment.mp4

Screen.Recording.2023-10-14.at.10.35.18.PM.mov

MacOS: Desktop

Screen.Recording.2023-10-14.at.10.35.18.PM.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f9d8b34b9a97b7b2
• Upwork Job ID: 1713715148645781504
• Last Price Increase: 2023-10-23

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f9d8b34b9a97b7b2

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (External)

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

WS list closes the RHP for a brief moment and then opens the new workspace settings after creating a new workspace

What is the root cause of that problem?

When creating a New Workspace, we will navigate to our admin first before navigating to our newly created workspace.

App/src/libs/actions/App.js

Lines 344 to 348 in 7791d32

	if (shouldNavigateToAdminChat) {
	Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(adminsChatReportID));
	}
	Navigation.navigate(ROUTES.WORKSPACE_INITIAL.getRoute(policyID));

Before navigation reboot we can use setParams to navigate to #admin while RHN is opening, however after reboot we need to navigate to admin room which caused this issue.

What changes do you think we should make in order to solve the problem?

Since we already had the functionality to navigate to #admin or #announce room in Workspace Initial page, we can remove this block of code:

 if (shouldNavigateToAdminChat) { 
     Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(adminsChatReportID)); 
 } 

Otherwise, I think that's fine to keep it like that.

What alternative solutions did you explore? (Optional)

N/A

[DylanDylann]

we will stop pushing the report screen below

FYI: #28573 (comment)

[melvin-bot]

@strepanier03, @ArekChr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!