[HOLD for payment 2024-11-18] [$500] [MEDIUM] Distance - Details page does not show error when invalid address is added in offline mode

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.85-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

1. Launch New Expensify app
2. Go to workspace chat
3. Create a distance request
4. Open the distance details page
5. Go offline
6. Tap on Distance > Add stop
7. Enter an invalid and non-existent address and save it
8. Go online
9. Tap on Distance

Expected Result:

The error message about invalid point show appear in both distance details page and distance editor

Actual Result:

The error message about invalid point only appears in the distance editor

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Bug6240583_1697551711068.Screen_Recording_20231017_192427_New_Expensify.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0101b2f741a0bdb5c5
• Upwork Job ID: 1714289099635212288
• Last Price Increase: 2023-10-24
• Automatic offers:
• aimane-chnaif | Contributor | 27429661
• dukenv0307 | Contributor | 27442050
• paultsimura | Contributor | 104962397

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0101b2f741a0bdb5c5

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The error message about invalid point only appears in the distance editor

What is the root cause of that problem?

We're not showing the waypoint error in the MoneyRequestConfirmationList and MoneyRequestView, but we're showing it in DistanceRequest here

What changes do you think we should make in order to solve the problem?

We need to get the waypoint error and display it in MoneyRequestConfirmationList here, similar to how we're showing the error for Description field here.

The logic to get error is similar to here. (we likely only need the route error here, the rest are client-side validation error in that screen)

It will look like this in the DistanceRequest page after the change:

This also happens for the MoneyRequestView, we should fix the same here.

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

@kadiealexander, @aimane-chnaif Eep! 4 days overdue now. Issues have feelings too...

[kadiealexander]

@aimane-chnaif please review above