[HOLD for payment 2023-11-09] [$500] IOU - When changing any value (merchant, description, date), the date is automatically reduced by one

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.90-2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

1. Open a chat with a regular user
2. Create a money request
3. Open the details page of the report
4. Verify that you can modify all values

Expected Result:

When changing any value (seller, description, date), the date should not automatically decrease by one

Actual Result:

When changing any value (seller, description, date), the date is automatically reduced by one

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Bug6249514_1698189860813.0-02-01-53d2895724c1bc78d1740cb2f6d914374c4f39f01b1ad3ceefc88a387afacd49_2bdea56ff09571ab__1_.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01419368cba963f673
• Upwork Job ID: 1716960193709166592
• Last Price Increase: 2023-10-24
• Automatic offers:
• wlegolas | Contributor | 27364971

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01419368cba963f673

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[wlegolas]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU - When changing any value (merchant, description, date), the date is automatically reduced by one

What is the root cause of that problem?

The problem is related to the process of formatting the date because it created a Date object using the current local time, that way when formatting the date the timezone is applied according to the current environment.

For example, the date is "2023-10-23", when is applied the format, the date will be "Sun Oct 22 2023 21:00:00 GMT-0300 (Brasilia Standard Time)", in my case is removed 3 hours from the modified date, that's why the result is always reduced by one.

This process to format the date occurs in the getCreated method in the TransactionUtils.

App/src/libs/TransactionUtils.ts

Lines 311 to 319 in 1c85ebe

	function getCreated(transaction: Transaction, dateFormat: string = CONST.DATE.FNS_FORMAT_STRING): string {
	const created = transaction?.modifiedCreated ? transaction.modifiedCreated : transaction?.created || '';
	const createdDate = new Date(created);
	if (isValid(createdDate)) {
	return format(createdDate, dateFormat);
	}
	return '';
	}

Regarding the date automatically being reduced by one when changing any information, is related to the process of updating the information in the modal, when the user clicks to save the information all information is sent to the backend, as the date always automatically decreases by one, this date is sent to the backend updating the transaction with this new date, and the request to the backend is done (request to the command EditMoneyRequest), the date information will be updated with the value from the response and reduce by one this value.

For example:

1. The user wants to update the "Description" field, and the current date information is "2023-10-23"
2. When the user requests to update the description, will be sent in the "created" property the value "2023-10-23"
3. When the request is done, in the response there is the property "modifiedCreated" that has the same value that was sent in the request "2023-10-23"
4. The component MoneyRequestView will update the "Date" information with the value from the response value "2023-10-23"
5. When calling the TransactionUtils.getCreated method the date is created using the local timezone and will be automatically reduced by one date, generating the value "2023-10-22"

What changes do you think we should make in order to solve the problem?

We should use the methods format, and utcToZonedTime from the library date-fns-tz (that the project already has in the dependencies) to first apply the "UTC" timezone in the date, after that format this date using the date format received from the getCreated method parameters.

What alternative solutions did you explore? (Optional)

N/A

POC

poc-issue-30303.mp4

[narefyev91]

Proposal from @wlegolas looks good to me #30303 (comment)
We need to show date based on user TimeZone - we should pick timezone from user profile - because user can manually change it
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @techievivek, see https://stackoverflow.com/c/expensify/questions/7972 for more details.