[HOLD for payment 2023-12-29] [$500] Room - In admin room, when copy to clipboard, the room name is not shown as link

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.1-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #30898

Action Performed:

1. Launch app
2. Tap start chat--- Room
3. Tap header---Invite a user to the room
4. In room page, long press the invite message and select copy to clipboard
5. Paste it in compose box and send the message
6. Note the copied message is displayed correctly
7. Navigate to LHN
8. Tap on admin room
9. Long press the invite message and select copy to clipboard
10. Paste it in compose box and send the message

Expected Result:

In admin room, when copy to clipboard, paste and send the invite message, the room name must be shown as link

Actual Result:

In admin room, when copy to clipboard, paste and send the invite message, the room name is not shown as link

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6284194_1700503426099.coca__droid.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a7ae55acdd8221b2
• Upwork Job ID: 1726667353323319296
• Last Price Increase: 2023-11-20
• Automatic offers:
• shubham1206agra | Reviewer | 27850800
• tienifr | Contributor | 27850801

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a7ae55acdd8221b2

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In admin room, when copy to clipboard, paste and send the invite message, the room name is not shown as link

What is the root cause of that problem?

When copying the invite message, we're not attaching the link information a to the room name

What changes do you think we should make in order to solve the problem?

When copying the invite message, attach the link information a to the room name, and copy it as HTML

1. Modify this to put room name in the a tag with the room link, the room id in room link can be taken from originalMessage.reportID
2. In here set the copied content as HTML, similar to what we already did here. Then when pasting to the composer, the room name will show as markdown and already includes the link

What alternative solutions did you explore? (Optional)

Add support for extracting room link from #... room name format, and add it as link when pasted. But this is more complicated, the above solution is enough to solve this already.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In admin room, room name is not copied as link when copying invite message.

What is the root cause of that problem?

We are just only including the room name as a text (not link) to the clipboard as in here:

App/src/libs/ReportUtils.js

Lines 4213 to 4219 in b4f001d

	const roomName = lodashGet(reportAction, 'originalMessage.roomName', '');
	if (roomName) {
	const preposition =
	reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.ROOMCHANGELOG.INVITE_TO_ROOM || reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.POLICYCHANGELOG.INVITE_TO_ROOM
	? ' to'
	: ' from';
	message += `${preposition} ${roomName}`;

What changes do you think we should make in order to solve the problem?

We should extract the room link from message.html and parse it to markdown (so that it appears as a markdown to the compose) and copy to clipboard text
Change this

App/src/libs/ReportUtils.js

Line 4219 in b4f001d

message += `${preposition} ${roomName}`;

to

        const messageHtml = lodashGet(_.last(lodashGet(reportAction, 'message', [{}])), 'html');
        const roomLink = /<\/mention-user> to (<a href=[^>]*>#[^<]*<\/a>)/.exec(messageHtml)[1];
        const parser = new ExpensiMark();
        message += `${preposition} ${parser.htmlToMarkdown(roomLink)}`;

POC

2023-11-21.13-12-45.mp4

What alternative solutions did you explore? (Optional)

[melvin-bot]

@MitchExpensify, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!