Skip to content

[Needs payment][Track Tax] Add new input fields for tax tracking in Money requests #31672

@MonilBhavsar

Description

@MonilBhavsar

Problem

Internal master Issue:https://github.com/Expensify/Expensify/issues/338212
Coming from this section in design doc https://docs.google.com/document/d/1nkusVPiYN3uYCJAH_2XknBv_oPpNOifVxheuxRvFTxs/edit?pli=1#bookmark=id.l319wrhremwa

This issue is divided in 2 phases to keep PR's small, test use cases efficiently and deliver in milestones

Phase 1

In phase 1, we create a simple input fields that can allow inserting, editing and viewing tax details
As discussed in design doc, we need to create tax selector and tax amount components. Also add handles to update transaction tax details in Onyx and also pass tax details to API

Components and handlers should be created in a new way following this refactor PR #28618

Phase 2

In phase 2, we'll add more logic to tax input fields.

  • Handling and displaying system messages when tax rates are updated
  • When updating category, we need to apply category expense rule and hence update tax rate field and tax amount field accordingly
  • As mentioned in design doc, only specific users can edit the tax details depending on the state of report

Why is this important?

To allow users to track tax on the expenses, and migration users to newdot.

Solution

Implement the section of the design doc

Issue OwnerCurrent Issue Owner: @kadiealexander
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fe3f2f6f3d94b969
  • Upwork Job ID: 1785541230062321664
  • Last Price Increase: 2024-05-01

Metadata

Metadata

Labels

DailyKSv2InternalRequires API changes or must be handled by Expensify staffNewFeatureSomething to build that is a new item.ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions