[$500] Tag - Child tags are not indented on list

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.2-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #31494

Action Performed:

Precondition: enable and add parent and child tags as an admin on OD

1. Log in to ND as an employee
2. Navigate to workspace chat
3. Tap the "+" > Request money
4. Enter the amount
5. On the confirmation screen, tap the "Show more" button
6. Select "Tags"

Expected Result:

Child tags are indented on the list

Actual Result:

Child tags are not indented. It is a different behavior with categories: child categories are indented

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f5ae8cc738a492b2
• Upwork Job ID: 1727436127562772480
• Last Price Increase: 2023-11-29
• Automatic offers:
• c3024 | Reviewer | 27886979
• wlegolas | Contributor | 27886980

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f5ae8cc738a492b2

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[wlegolas]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tag - Child tags are not indented on list

What is the root cause of that problem?

The method getTagsOptions is used to get the Tags to be displayed, this method does not create a tree structure when the tag name has the format [parent]:[child].

App/src/libs/OptionsListUtils.js

Lines 912 to 925 in a5e4fb3

	function getTagsOptions(tags) {
	return _.map(tags, (tag) => {
	// This is to remove unnecessary escaping backslash in tag name sent from backend.
	const tagName = tag.name && tag.name.replace(/\\{1,2}:/g, ':');
	return {
	text: tagName,
	keyForList: tagName,
	searchText: tagName,
	tooltipText: tagName,
	isDisabled: !tag.enabled,
	};
	});
	}

To generate the Tag options is used the sequence of methods from the OptionsListUtils: getFilteredOptions -> getOptions -> getTagListSections -> getTagsOptions

What changes do you think we should make in order to solve the problem?

We should change the getTagsOptions method to call the getCategoryOptionTree method with the tags to create the tree structure when the tag name has the format [parent]:[child].

For example,

/**
 * Transforms the provided tags into objects with a specific structure.
 *
 * @param {Object[]} tags - an initial tag array
 * @param {Boolean} tags[].enabled - a flag to enable/disable option in a list
 * @param {String} tags[].name - a name of an option
 * @returns {Array<Object>}
 */
function getTagsOptions(tags) {
    const normalizedTags = _.map(tags, (tag) => {
        // This is to remove unnecessary escaping backslash in tag name sent from backend.
        const tagName = tag.name && tag.name.replace(/\\{1,2}:/g, ':');

        return {
            ...tag,
            name: tagName,
        };
    });

    return getCategoryOptionTree(normalizedTags);
}

What alternative solutions did you explore? (Optional)

N/A

POC

poc-issue-31753.mov

[MitchExpensify]

Having some trouble reproducing this, do you have a video of your reproduction @lanitochka17 ?

[melvin-bot]

@MitchExpensify, @c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick!