[HOLD for payment 2023-12-29] [$500] mWeb/Chrome-Contact methods-Confirmation window moves when trying to remove secondary contact method

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.5-7
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any account
3. Go to Settings - Profile - Contact method - New contract method
4. Add a new contract method, but not validate
5. Open just added contact method
6. When the keyboard opens, tap on the remove button

Expected Result:

Confirmation window not moves

Actual Result:

Confirmation window moves

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6295867_1701344893404.Record_2023-11-29-23-19-45.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010d076df7ad5db3f2
• Upwork Job ID: 1730200102411456512
• Last Price Increase: 2023-11-30
• Automatic offers:
• dukenv0307 | Contributor | 28035618

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010d076df7ad5db3f2

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Confirmation window moves

What is the root cause of that problem?

We're not waiting until the keyboard closes before showing the modal

What changes do you think we should make in order to solve the problem?

Run the code to show the modal (here or here) inside InteractionManager.runAfterInteractions

What alternative solutions did you explore? (Optional)

Other places that have the issue can be fixed similarly.

An alternative is we can move the logic inside Modal, if the isVisible prop passed in changes from false to true, and another input is focused, it will blur the input/close the keyboard first before set the internal visibility (we'll maintain the inner isVisible of the modal in a state) of the modal to true inside InteractionManager.runAfterInteractions and thus showing the modal.

Instead of InteractionManager.runAfterInteractions, we might be able to use Keyboard.addListener('keyboardDidHide' which will work for native, but I'm not sure this will work on web

[yh-0218]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Confirmation window moves

What is the root cause of that problem?

Because keyboard is closed During show the modal.

What changes do you think we should make in order to solve the problem?

we need update like this.

toggleDeleteModal(isOpen) {
        Keyboard.dismiss();
        InteractionManager.runAfterInteractions(() => {
                 this.setState({isDeleteModalOpen: isOpen});
        });
}

App/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.js

Lines 211 to 215 in e2f4214

	toggleDeleteModal(isOpen) {
	this.setState({isDeleteModalOpen: isOpen});
	Keyboard.dismiss();
	}

What alternative solutions did you explore? (Optional)

[ebauger]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Cumulative Layout Shift (CLS) when the delete modal is close.

What is the root cause of that problem?

CLS : https://web.dev/articles/cls

Can be a device performance issue

What changes do you think we should make in order to solve the problem?

Verify if this new implementation can solve the issue and don't make a regression for other platforms on :

App/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.js

Lines 211 to 215 in e2f4214

	toggleDeleteModal(isOpen) {
	this.setState({isDeleteModalOpen: isOpen});
	Keyboard.dismiss();
	}

What alternative solutions did you explore? (Optional)

I try on mWeb Safari and the initial logic work. I can investigate the cause if the performance issue in mWeb Android.

Example how to proceed : https://web.dev/articles/optimize-cls