[HOLD for #32413][$500] Expense report title is too far away from avatar in page header

[m-natarajan]

• HELD on [HOLD for payment 2023-12-29] [$500] Expense avatar and Report avatar in LHN look incorrect #32413

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.7.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1701391579217569

Action Performed:

Go to an expense report

Expected Result:

The expense report title and small subtext (From...) should be just 12px away from the room avatar

Actual Result:

The expense report title and small subtext (From...) are too far to the right of the avatar in the page header compared to other chats (DMs, rooms, etc)

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01420f85f91e69170f
• Upwork Job ID: 1731339996183658496
• Last Price Increase: 2023-12-03
• Automatic offers:
• situchan | Contributor | 28014682

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01420f85f91e69170f

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The expense report title and small subtext (From...) are too far to the right of the avatar in the page header compared to other chats (DMs, rooms, etc)

What is the root cause of that problem?

We're not applying styles.ml4 if it's an expense request here.

What changes do you think we should make in order to solve the problem?

Apply styles.ml4 if it's an expense request.

We can remove the && !isExpenseRequest condition

What alternative solutions did you explore? (Optional)

NA

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense report title is too far away from avatar in page header

What is the root cause of that problem?

isExpenseRequest condition is used for more 16px margin but this doesn't filter money request header avatar

App/src/components/AvatarWithDisplayName.js

Line 135 in 1682be4

<View style={[styles.flex1, styles.flexColumn, shouldShowSubscriptAvatar && !isExpenseRequest ? styles.ml4 : {}]}>

What changes do you think we should make in order to solve the problem?

update condition above to
shouldShowSubscriptAvatar && !isExpenseRequest && !isMoneyRequestOrReport

or fully remove styles.ml4

[yh-0218]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense report title is too far away from avatar in page header

What is the root cause of that problem?

App/src/components/AvatarWithDisplayName.js

Line 135 in 1682be4

<View style={[styles.flex1, styles.flexColumn, shouldShowSubscriptAvatar && !isExpenseRequest ? styles.ml4 : {}]}>

What changes do you think we should make in order to solve the problem?

need to update like this
<View style={[styles.flex1, styles.flexColumn]} />

[shubham1206agra]

This seems to be fixed when I apply #32413 (comment)