[HOLD for payment 2024-01-25] [$500] [Wave 6: Workspace Chats] IOU - Chat with IOU shows "This is beginning" in LHN after login and no Pay elsewhere in IOU preview

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.9-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: User has received IOU request

1. Log out
2. Log in
3. Open the chat with IOU request

Expected Result:

The chat preview in LHN will show the latest IOU action
After opening the chat, the IOU preview shows Pay elsewhere

Actual Result:

The chat preview in LHN shows "This is the beginning of" instead of the latest IOU action
After opening the chat, the IOU preview does not show Pay elsewhere unless the IOU report is visited and user returns to the main chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6304418_1701953266666.20231207_160647.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ff0e7b70f9f8b4d4
• Upwork Job ID: 1732753199542329344
• Last Price Increase: 2023-12-07
• Automatic offers:
• cubuspl42 | Reviewer | 28080970
• paultsimura | Contributor | 28080971

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ff0e7b70f9f8b4d4

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After login, the report previews. are displayed incorrectly.

What is the root cause of that problem?

This seems like a BE issue: on the OpenApp request, only chat reports are loaded. As a result, the ReportPreview actions show invalid data, since the IOU Reports are absent from Onyx.
This might be a side-effect of #29593

What changes do you think we should make in order to solve the problem?

This should be fixed on the BE side by either loading all the accessible reports on OpenApp, or by modifying the OpenReport API response to return not only the requested report but also all the associated IOU Reports (or even all the child reports).

To fix this solely on the FE side, we can add an OpenReport call on the ReportPreview actions if the IOU reports are missing. This will fetch the report from BE once the report action is mounted:

    useEffect(() => {
        if (lodashHas(props.iouReport, 'reportID')) {
            return;
        }

        Report.openReport(props.iouReportID);
    }, []);

What alternative solutions did you explore? (Optional)

[jakub-trzebiatowski]

@paultsimura Thank you for investigating this!

🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.