[HOLD for payment 2024-01-04] [$500] Mention - First letter of username becomes lowercase when entering full name after @ mention

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.10-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat
3. Type @
4. Enter the display name of a user in which the first letter is in capital letter

Expected Result:

There will be no change in the username in the suggestion list when the display name is fully entered

Actual Result:

When the display name is fully entered, the first letter of the username in the suggestion list becomes lowercase

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011f33f898020e3b5a
• Upwork Job ID: 1733228985608507392
• Last Price Increase: 2023-12-15
• Automatic offers:
• situchan | Reviewer | 28067127
• c3024 | Contributor | 28067128

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011f33f898020e3b5a

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[anduimagui]

@lanitochka17 looks like this may not be the correct video for the issue? It's looking at requesting money

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Searching for full name for mentions shows the result in mention suggestions with name in lower case.

What is the root cause of that problem?

We get the display name rendered in suggestions from here

App/src/components/MentionSuggestions.tsx

Line 64 in adbeba1

const styledDisplayName = getStyledTextArray(item.text, prefix);

and we push text into texts and return them here

App/src/libs/GetStyledTextArray.ts

Lines 13 to 31 in ed5009d

	if (prefixLocation === 0 && prefix.length === name.length) {
	texts.push({text: prefixLowercase, isColored: true});
	} else if (prefixLocation === 0 && prefix.length !== name.length) {
	texts.push({text: name.slice(0, prefix.length), isColored: true}, {text: name.slice(prefix.length), isColored: false});
	} else if (prefixLocation > 0 && prefix.length !== name.length) {
	texts.push(
	{text: name.slice(0, prefixLocation), isColored: false},
	{
	text: name.slice(prefixLocation, prefixLocation + prefix.length),
	isColored: true,
	},
	{
	text: name.slice(prefixLocation + prefix.length),
	isColored: false,
	},
	);
	} else {
	texts.push({text: name, isColored: false});
	}

All conditions except when name length equals to prefix length, use name to get text but for this equal condition here

App/src/libs/GetStyledTextArray.ts

Lines 13 to 14 in ed5009d

	if (prefixLocation === 0 && prefix.length === name.length) {
	texts.push({text: prefixLowercase, isColored: true});

we are getting text from the lower case prefix which is causing the issue.

What changes do you think we should make in order to solve the problem?

We should get the text from name similar to other conditions.
So we change this line here

App/src/libs/GetStyledTextArray.ts

Line 14 in ed5009d

texts.push({text: prefixLowercase, isColored: true});

to

texts.push({text: name, isColored: true});

What alternative solutions did you explore? (Optional)

Result

noLowerCase.mov

[lanitochka17]

I am sorry, adding the correct video

bandicam.2023-12-08.22-35-44-597.mp4