[HOLD for payment 2023-12-20] [$500] Split - Participants under “Split with” list disappear after unselecting them

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.11-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com.
2. Go to group chat > + > Split bill.
3. Enter amount > Next.
4. Unselect the participants.

Expected Result:

Group participants will not disappear from the “Split with” list after unselecting them.

Actual Result:

Group participants disappear from the “Split with” list after unselecting them.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6308971_1702302486695.bandicam_2023-12-11_19-56-33-445__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01103b76f36fd3edb8
• Upwork Job ID: 1734224694853259264
• Last Price Increase: 2023-12-11
• Automatic offers:
• s-alves10 | Contributor | 28035106

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[tgolen]

I'll look into it this morning.

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Participants under "Split with" list disappear when unselecting them

What is the root cause of that problem?

This is a regression of the PR #28618

The root cause is in the following code segment

App/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js

Line 371 in a16df0d

const unselectedParticipants = _.filter(selectedParticipantsFiltered, (participant) => !participant.selected);

In the above code, selectedParticipantsFiltered is a filtered participants list(selected = true) as you can see here

App/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js

Line 361 in a16df0d

const selectedParticipantsFiltered = useMemo(() => _.filter(selectedParticipants, (participant) => participant.selected), [selectedParticipants]);

What changes do you think we should make in order to solve the problem?

Update the above line to

        const unselectedParticipants = _.filter(selectedParticipants, (participant) => !participant.selected);

This works as expected

What alternative solutions did you explore? (Optional)

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.