[Paid] Android - IOU - App crashes when adding a receipt from gallery in confirmation page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.11-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch New Expensify app
2. Go to 1:1 DM > + > Request money
3. Enter amount and proceed to confirmation page
4. Tap 3-dot menu > Add receipt
5. Upload a receipt from gallery

Expected Result:

App does not crash

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6309601_1702326171227.Screen_Recording_20231212_011607_New_Expensify.mp4

logs.txt

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @JmillsExpensify

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @grgia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - IOU - App crashes when adding a receipt from gallery in confirmation page

What is the root cause of that problem?

App crashes on this line:

App/src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

Line 221 in 86a2521

_.some(participants, (participant) => participant.searchText.toLowerCase().includes(searchTerm.trim().toLowerCase())),

participant.searchText is undefined. Why?

After scanning receipt, there's no navigation goBack logic.

This doesn't happen when capture photo from camera because that logic is here:

App/src/pages/iou/request/step/IOURequestStepScan/index.native.js

Lines 138 to 141 in 86a2521

	if (backTo) {
	Navigation.goBack(backTo);
	return;
	}

What changes do you think we should make in order to solve the problem?

Apply same logic above to gallery picker:

App/src/pages/iou/request/step/IOURequestStepScan/index.native.js

Line 231 in 86a2521

This bug also happens on mWeb, when capture photo. The fix is same as above so add navigation goBack logic here:

App/src/pages/iou/request/step/IOURequestStepScan/index.js

Line 156 in 86a2521

similar to here: (document picker)

App/src/pages/iou/request/step/IOURequestStepScan/index.js

Lines 123 to 126 in 86a2521

	if (backTo) {
	Navigation.goBack(backTo);
	return;
	}

[luacmartins]

@mkhutornyi are you able to work on a PR within the next hour?

[mkhutornyi]

yes, I am

[mkhutornyi]

For speed-up, I can raise one PR for 2 issue fixes.
Here's another one - #32844 I found root cause & solution

[luacmartins]

Cool, assigned you to the issue. Let me know when the PR is ready