[HOLD for payment 2024-06-20][Unvalidated Sign-Up] [$500] Add validation flow to bank account set up

[NikkiWines]

Action Performed:

1. Create an unvalidated account on New Expensify by logging into expensify.com with an account on a public domain
2. Create a workspace for that account
3. Navigate to your Workspace >
4. Select either Connect Online With Plaid or Connect Manually

Expected Result:

5. User should see a page with a view to validate their account and receive a notification to validate their bank account.
   • We can use the existing RequestContactMethodValidateCode command for this
6. Pressing the < should take them back to the Connect Bank Account with the two options mentioned in step 4.
7. Once the user verifies their account they should be able to continue with the standard bank account setup flow
   • Verifying the account can be done via the existing ValidateLogin command, though the navigation will need to be updated so that the user is not routed away from the bank account flow.

Actual Result:

User is blocked from adding a bank account by an error message.

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0160a09bc15c94c626
• Upwork Job ID: 1735348005410426880
• Last Price Increase: 2023-12-14
• Automatic offers:
• dukenv0307 | Contributor | 0

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Triggered auto assignment to @lschurr (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add validation flow to bank account set up

What is the root cause of that problem?

It's a new feature

What changes do you think we should make in order to solve the problem?

1. In BankAccountStep, subscribe loginList from Onyx and get loginNames = _.keys(props.loginList)

2. Create a translation in bankAccount.validateAccountError like phrase3: or verify the account here. And then add this in BankAccountStep after this line

<TextLink 
    fontSize={variables.fontSizeLabel}
    onPress={() => {
        const login = props.loginList[loginNames[0]];

        Navigation.navigate(ROUTES.SETTINGS_CONTACT_METHOD_DETAILS.getRoute(login.partnerUserID || loginNames[0]));
    }}
>
    {props.translate('bankAccount.validateAccountError.phrase3')}
</TextLink>

App/src/pages/ReimbursementAccount/BankAccountStep.js

Line 174 in e81ed8f

</TextLink>

3. In validateSecondaryLogin function, update validated of user as true in the successData

{
    onyxMethod: Onyx.METHOD.MERGE,
    key: ONYXKEYS.USER,
    value: {
        validated: true
    }
}

App/src/libs/actions/User.js

Line 368 in e81ed8f

function validateSecondaryLogin(contactMethod, validateCode) {

What alternative solutions did you explore? (Optional)

NA

Result

Screen.Recording.2023-12-14.at.15.36.03.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0160a09bc15c94c626