[HOLD for payment 2024-01-17] Web – Chat – Edit mode doesn’t open when Press ArrowUp in DM if delete message using keyboard

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.13-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Intenral Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in with any account
3. Navigate to the conversation between user A and B in both devices
4. Send two messages to user B
5. As user A press ArrowUp in the DM. Verify that the last message user A sent in the chat enters edit mode
6. Delete all the text while editing the comment and press Enter
7. Press ArrowUp in the DM

Expected Result:

The first message sent in step 4 enters edit mode

Actual Result:

Focus is losted. Nothing happenes. Last message edit mode doesn’t open when Press ArrowUp in the DM if delete the previous message using keyboard

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6313468_1702579313132.Last_message_edit_mode_doesn_t_open_when_Press_ArrowUp.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[situchan]

This is regression from #32474
@tylerkaraszewski if we end up reverting approach, feel free to merge #33133 since it's straight revert

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Focus is losted. Nothing happenes. Last message edit mode doesn’t open when Press ArrowUp in the DM if delete the previous message using keyboard

What is the root cause of that problem?

This is regression from this PR #32474 which makes composer doesn't re-focus after deleting the message

What changes do you think we should make in order to solve the problem?

1. Revert this PR fix: hide pending deleted actions #32474

2. To fix the issue of this PR fix: hide pending deleted actions #32474, We should check here if the reportAction is deleted by using isDeletedAction, we will return false because this reportAction still in the list of reportActions with optimistic data but it's invisible in the UI.

if (ReportActionsUtils.isDeletedAction(reportAction) && !isOffline) {
    return false;
}

App/src/pages/home/report/ReportActionsList.js

Line 334 in 3a44f77

let shouldDisplay = false;

What alternative solutions did you explore? (Optional)

[Julesssss]

I can reproduce but this is only occuring on web/desktop and is a minor issue. Removing blocker label