[HOLD for payment 2023-12-29] Fix require cycle from clearReportNotifications.ts

[arosiclair]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: N/A
Reproducible in staging?: N/A
Reproducible in production?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: N/A
Expensify/Expensify Issue URL:
Issue reported by: @arosiclair
Slack conversation: N/A

Action Performed:

Run NewDot in dev on Android/iOS

Expected Result:

No warnings about require cycles appear in logs

Actual Result:

 WARN  Require cycle: src/libs/actions/Report.ts -> src/libs/Notification/clearReportNotifications/index.native.ts -> src/libs/Notification/PushNotification/index.native.ts -> src/libs/Notification/PushNotification/ForegroundNotifications/index.ios.ts -> src/libs/Notification/PushNotification/shouldShowPushNotification.ts -> src/libs/actions/Report.ts

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012e8796edd86cd329
• Upwork Job ID: 1736418796306968576
• Last Price Increase: 2023-12-17

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012e8796edd86cd329

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

[arosiclair]

@conorpendergrast no triage needed for this atm. This is a dev issue.