[HOLD for payment 2023-12-29] [HOLD for payment 2023-12-28] Scan - "Reply in thread" is not present for IOU preview with ongoing smartscanning

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.14-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Click FAB > Request money > Manual.
2. Request money from a user.
3. In 1:1 DM where the money is requested, right click on the IOU preview.
4. Click on the IOU preview to open report page and right click on the IOU preview.
5. Note that "Reply in thread" is present.
6. Repeat Step 1-4 with a Scan request.

Expected Result:

"Reply in thread" is present for IOU preview with ongoing smart scanning.

Actual Result:

"Reply in thread" is not present for IOU preview with ongoing smart scanning.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6321251_1703078730828.bandicam_2023-12-20_15-57-05-794.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @narefyev91

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[kbecciv]

Not reproducible on production

bandicam.2023-12-20.16-02-07-482.mp4

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Reply in thread" is not present for IOU preview with ongoing smart scanning.

What is the root cause of that problem?

We are not allowing reply in thread for whisper action. So when the request is scanning, it's wishper action and then no reply in thread option

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Line 151 in 9ea6b39

!isWhisperAction &&

What changes do you think we should make in order to solve the problem?

We should allow reply in thread for IOU action even if it's a whisper

(!isWhisperAction || reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.IOU)

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Line 151 in 9ea6b39

!isWhisperAction &&

What alternative solutions did you explore? (Optional)

NA

[aldo-expensify]

hum.. if it is a whisper action, other users in the conversation won't see it right? I find it strange to be able to start a thread from a whisper since others won't be able to see the parent report action

[aldo-expensify]

Does the smartscan preview stop being a whisper once the smartscan process is finished? In such case it would make sense to me that a thread can exist from it because it will become visible for other participants

[aldo-expensify]

Does the smartscan preview stop being a whisper once the smartscan process is finished?

From my testing, apparently not.

[aldo-expensify]

hmm from the admin's perspective, the admin can see this whisper:

🤯

[aldo-expensify]

The "Only visible to you" is a lie then:

[dukenv0307]

@aldo-expensify what is the next step here? Should we fix this issue or it's intendtional.