[HOLD for payment 2024-01-17] [$500] Grey box is shown instead of bank icon

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.18-1
Reproducible in staging?: y
Reproducible in production?: not able to check
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shubham1206agra
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1703677023896169

Action Performed:

1. Go to Workspace > Bank Account
2. Select Connect online via plaid
3. Select any bank, and complete the plaid process
4. Observe the icon next to bank name

Expected Result:

Bank Icon should be shown

Actual Result:

Grey Box is shown

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018bcfe6522be3b9f5
• Upwork Job ID: 1740403705181048832
• Last Price Increase: 2023-12-28
• Automatic offers:
• shubham1206agra | Contributor | 28071698
• Pujan92 | Contributor | 28071779

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Grey box is shown instead of bank icon in plaid bank account step

What is the root cause of that problem?

unnecessary fill prop is added to Icon in AddPlaidBankAccount

App/src/components/AddPlaidBankAccount.js

Lines 247 to 253 in 9e81447

	<Icon
	src={icon}
	height={iconSize}
	width={iconSize}
	additionalStyles={iconStyles}
	fill={theme.icon}
	/>

What changes do you think we should make in order to solve the problem?

remove that prop

Demo:

demo.mov

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bank icon filled with grey color

What is the root cause of that problem?

In this PR, for many places we have added fill property to Illustrations or images. In some screenshots just showing the image issue in diff component.

• ImageCropView
• AddPlaidBankAccount
• DeeplinkRedirectLoadingIndicator
• ValidateCodeModal
• LogInWithShortLivedAuthTokenPage

What changes do you think we should make in order to solve the problem?

Remove fill property for Illustrations or images from all these components.