[HOLD for payment 2024-02-09] [$500] Android - Workspace - WS image is displayed without background

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.18-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap on a Workspace ( with single letter name like eg:"Z")
3. Tap Workspace icon in header
4. Tap Workspace icon in Details page
5. Note Workspace image is displayed with background in mweb.
6. Launch app
7. Repeat step 2 - step 4
8. Note Workspace image is displayed without background in Android

Expected Result:

Workspace image must be displayed with background

Actual Result:

Workspace image is displayed without background in Android but with background in mweb

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6327135_1703716298402.az_recorder_20231228_001317.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010b6d3a83f995ac38
• Upwork Job ID: 1740172374538711040
• Last Price Increase: 2024-01-04
• Automatic offers:
• tienifr | Contributor | 28091060

Issue Owner

Current Issue Owner: @MitchExpensify

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010b6d3a83f995ac38

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace image is displayed without background in Android but with background in mweb

What is the root cause of that problem?

Since the SVG migration to using expo-image, it no longer match this condition, because SVG is no longer React components, it's now statically imported

What changes do you think we should make in order to solve the problem?

Check if source is number here instead, because the statically imported SVG will have source as number, it's native iOS & Android's static asset representation.

if (typeof source === 'number' && !transactionID) {

The transactionID check is so that we exclude receipt case, since generic receipt is an image and it should never display as Icon. An alternative of this is that we can move all the checks related to receipt like here and here to above the source number check. But I prefer the transactionID check since it's more robust.

What alternative solutions did you explore? (Optional)

Since source number could be images as well, there could be risk of the image showing as icon if that happens (although currently I didn't find any such case in the app except for the generic receipt above). If we want to avoid that risk entirely, we can add another prop like isImage to indicate the file type (or add type to the file), and the condition of source above will take into account the file type as well, so only if the source is number, and it is CSV (or it's not image), we'll use the <Icon>.

[shubham1206agra]

@NicMendonca @sobitneupane Can we combine this GH with #33616?

As #33616 (comment) seems to solve both issues.

[tienifr]

@shubham1206agra they have 2 different root causes, in #33616 the solution that's accepted won't fix this issue.

But we can hold this issue on that one though.

cc @NicMendonca @sobitneupane