[Payment due 3/6][$500] Font in "Hold Request" reason heading text is looks wrong

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.43-7
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1708436683366409

Action Performed:

1. Create a IOU request
2. Open the IOU details and click on 3 dot and select "Hold request" option
3. Look at the Explain why you're holding this request

Expected Result:

Should match with same font in other section like display name

Actual Result:

It shows with different font.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017627c882f3450aea
• Upwork Job ID: 1760361321264185344
• Last Price Increase: 2024-02-21
• Automatic offers:
• s77rt | Reviewer | 0
• shahinyan11 | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017627c882f3450aea

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[shahinyan11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Font in "Hold Request" reason heading text is looks wrong

What is the root cause of that problem?

the styles.textHeadline style is set for this text

What changes do you think we should make in order to solve the problem?

Change this style with corresponding style or remove it

What alternative solutions did you explore? (Optional)

[eucool]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Font in "Hold Request" reason heading text is looks wrong

What is the root cause of that problem?

We currently set the text style to textHeadline.

App/src/pages/iou/HoldReasonPage.tsx

Line 79 in 04737ae

<Text style={[styles.textHeadline, styles.mb6]}>{translate('iou.explainHold')}</Text>

What changes do you think we should make in order to solve the problem?

Remove the corresponding style don't set it to anything, only keep margin

What alternative solutions did you explore? (Optional)

[eucool]

btw, regression from #33897

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

It shows with different font.

What is the root cause of that problem?

The Explain why you're holding this request has textHeadline which has the same fontFamily as title of HeaderWithBackButton but the font size is larger.

App/src/pages/iou/HoldReasonPage.tsx

Line 79 in 04737ae

<Text style={[styles.textHeadline, styles.mb6]}>{translate('iou.explainHold')}</Text>

What changes do you think we should make in order to solve the problem?

We can use textHeadlineH1 style that we used for the title of HeaderWithBackButton or use headerText style that we used for the display name in HeaderView

App/src/pages/iou/HoldReasonPage.tsx

Line 79 in 04737ae

<Text style={[styles.textHeadline, styles.mb6]}>{translate('iou.explainHold')}</Text>

What alternative solutions did you explore? (Optional)

NA

[s77rt]

@shahinyan11 Thanks for the proposal. Your RCA is correct. The solution looks good to me.

🎀 👀 🎀 C+ reviewed
Link to proposal