[HOLD for payment 2024-04-09] [$500] Composer defocuses when editing parent message in thread

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.56-0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #37566
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com.
2. Go to any chat.
3. Send a message containing inline image markdown. Example:
   An inline image and some text
4. Right click on the message > Edit comment.
5. Focus the cursor anywhere in the editor.
6. Note that the composer will not defocus.
7. Right click on the message > Reply in thread.
8. Right click on the parent message > Edit comment.
9. Focus the cursor anywhere in the editor.

Expected Result:

The composer will not defocus.

Actual Result:

The composer defocuses when editing message with inline image mark down in thread.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6424058_1711173003900.20240323_134637.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012dd2062cbe841507
• Upwork Job ID: 1772340169085984768
• Last Price Increase: 2024-03-25
• Automatic offers:
• jjcoffee | Reviewer | 0
• bernhardoj | Contributor | 0

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #vip-bills

[amyevans]

This is related to a new feature and also pretty minor so not worth considering a blocker.

@kidroca do you have bandwidth to take this on and fix as polish? If not I can open it up to external proposals. cc @situchan @marcaaron

[amyevans]

Hmm actually I'm going to walk back my comment that it's related to the Image Markdown PR, I think it was just incidental that it was discovered during QA there. I can reproduce the bug on main with that PR reverted, and I can also reproduce on a comment that does not include image markdown.

Will continue to investigate...

[situchan]

Agree, I am not convinced why composer focus behavior is related to image MD.