[HOLD for payment 2024-05-08] [$250] Profile - Display name is not updating in "Share Somewhere" section

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.60-1
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to Profile.
2. Add or change the Display name.
3. Use FAB to assign a task.
4. Add a title and click "Next" to share somewhere.
5. Notice that the Display name isn't updated for the account email (email signed in).

Expected Result:

When the Display name is changed, it should be updated in the "Share Somewhere" section for the account email (email signed in).

Actual Result:

Display name is not updating in "Share Somewhere" section

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6437941_1712234508566.Screen_Recording_2024-04-04_at_1.14.37_AM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0109207e4c67cd7686
• Upwork Job ID: 1776016111925432320
• Last Price Increase: 2024-04-11
• Automatic offers:
• hungvu193 | Reviewer | 0
• nkdengineer | Contributor | 0

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @bondydaa (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #vip-vsb

[bondydaa]

I'm looking into this, nothing in the checklist stands out to me that might be something that broke this so having to dive into the code and see what exactly gets called.

[bondydaa]

okay i don't think it's a problem with the API, i see the response coming back properly with the updated data

And I see in the onyx db that it's been updated there

So this makes me think that for some reason the Share Somewhere component isn't properly subscribing to the onyx data or something so going to take a closer look at that.

[bondydaa]

Hmm this PR is sus to me after looking at the components involved here: #38207

[bondydaa]

okay yes I believe I've confirmed this by testing locally.

checking out 1.4.60-1 locally I see the same behavior and then reverting it I can't reproduce it anymore.

cc @grgia @hungvu193 @TMisiukiewicz can you take a look here?

[bondydaa]

I guess what we need is a way to invalidate the option list cache when personal details are updated, if there is a way to do that in the PR can you let me know?

or if that's still to come then maybe we consider this not a blocker?

makes me think of my favorite tweet 😂 https://twitter.com/codinghorror/status/506010907021828096