[HOLD for payment 2024-04-15] [$250] Taxes - Transaction thread shows skeleton loading when saving 0.00 tax amount for second time

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.60-8
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #33927
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• User is an employee of Collect workspace with tax rates.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create a manual request with tax exempt (0%).
4. Go to transaction thread.
5. Click Tax amount.
6. Save it without entering any amount.
7. Repeat Step 5 and 6.

Expected Result:

In Step 6, when saving 0.00 tax amount, the system message will not show $NaN amount,
In Step 7, when saving 0.00 tax amount for the second time, the app will not show skeleton loading.

Actual Result:

In Step 6, $NaN is shown briefly in the system message.
In Step 7, transaction thread shows skeleton loading when saving 0.00 tax amount for second time.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6438827_1712298111790.20240405_141500.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01091a68b65c340a6a
• Upwork Job ID: 1776234872385998848
• Last Price Increase: 2024-04-05
• Automatic offers:
• DylanDylann | Reviewer | 0

[melvin-bot]

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@bfitzexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[MonilBhavsar]

Looking here...