DEV - Throws warning when starting desktop

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: Dev
Reproducible in staging?: dev
Reproducible in production?: dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shubham1206agra
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1712819917386169

Action Performed:

1. Open desktop app in dev environment

Expected Result:

Opens without any issues

Actual Result:

Error message is thrown

Onyx DevTools - Error: ReferenceError: window is not defined
[Electron] at DevTools.connectViaExtension (webpack://new.expensify/./node_modules/react-native-onyx/dist/DevTools.js?:14:35)
[Electron] at new DevTools (webpack://new.expensify/./node_modules/react-native-onyx/dist/DevTools.js?:6:31)
[Electron] at eval (webpack://new.expensify/./node_modules/react-native-onyx/dist/DevTools.js?:69:22)
[Electron] at ./node_modules/react-native-onyx/dist/DevTools.js (/Users/prachiagrawal/code/App/desktop/dist/main.js:2717:1)
[Electron] at webpack_require (/Users/prachiagrawal/code/App/desktop/dist/main.js:5411:42)
[Electron] at eval (webpack://new.expensify/./node_modules/react-native-onyx/dist/Onyx.js?:37:36)
[Electron] at ./node_modules/react-native-onyx/dist/Onyx.js (/Users/prachiagrawal/code/App/desktop/dist/main.js:2739:1)
[Electron] at webpack_require (/Users/prachiagrawal/code/App/desktop/dist/main.js:5411:42)
[Electron] at eval (webpack://new.expensify/./node_modules/react-native-onyx/dist/index.js?:7:32)
[Electron] at ./node_modules/react-native-onyx/dist/index.js (/Users/prachiagrawal/code/App/desktop/dist/main.js:2816:1)

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[mallenexpensify]

Checking on in #engineering-chat

[mallenexpensify]

@pac-guerreiro , 👀 plz, this might be related to

• feat: add integration with Redux DevTools react-native-onyx#438

[pac-guerreiro]

@mallenexpensify Yeah... this is one me 😅 I can take a look into it if you want!

[mallenexpensify]

Thanks for the quick reply, assigned to you. cc @marcaaron and @AndrewGable since you were the reviewers on the PR. Not assigning to either of ya, do so if you want.

[pac-guerreiro]

@m-natarajan

I'm unable to reproduce this. Does the app crash to you? Are you running the app through npm run desktop?