Distance - Distance rate currency does not update after changing distance expense currency

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.64-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat as admin.
3. Create a distance request
4. Go to transaction thread.
5. Click Amount.
6. Change the currency and save it.

Expected Result:

The distance rate currency will also update.

Actual Result:

The distance rate currency does not update after changing distance expense currency.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6457566_1713800768445.rate.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance rate currency does not update after changing distance expense currency

What is the root cause of that problem?

We are passing the wrong currency here. We should pass transaction currency.

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 190 in 6abd9fd

const rateToDisplay = DistanceRequestUtils.getRateForDisplay(unit, rate, currency, translate, toLocaleDigit, isOffline);

What changes do you think we should make in order to solve the problem?

We should pass transactionCurrency here instead of currency

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 190 in 6abd9fd

const rateToDisplay = DistanceRequestUtils.getRateForDisplay(unit, rate, currency, translate, toLocaleDigit, isOffline);

const rateToDisplay = DistanceRequestUtils.getRateForDisplay(unit, rate, transactionCurrency, translate, toLocaleDigit, isOffline);

We should fix this in other places too where we are passing incorrect currency

What alternative solutions did you explore? (Optional)

[mountiny]

@koko57 @neil-marcellini this might be related to this PR, can you please have a look? #38543

[koko57]

@mountiny as it is related to my PR I'd like to fix. @neil-marcellini but should we be able to edit transaction currency when we have a rate chosen?

[neil-marcellini]

I'm not quite sure that I agree with expected behavior here. On production we have the same thing where the rate currency doesn't change when the transaction currency changes. In fact I think that makes it more clear that the currency was manually adjusted.

It kind of seems like it would make more sense to prevent editing the amount and currency entirely for distance requests, but I think there was some reason that we wanted to allow this. I will ask in Slack. Either way, this is not a blocker because it occurs on production. @kbecciv please be more careful to check if the problem occurs on production next time. The fields changed but the problem is essentially the same.

[neil-marcellini]

@rlinoz may I take this one over please?