[$250] Chat - Phone number mention in edit comment shows @expensify.sms

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.65-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4506240
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause_internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to chat.
3. Send a phone number mention.
4. Right click on the message > Edit comment.

Expected Result:

Phone number mention in edit comment will not show @expensify.sms.

Actual Result:

Phone number mention in edit comment shows @expensify.sms.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6461260_1714031914746.bandicam_2024-04-25_15-56-40-903.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f67e599996d40e27
• Upwork Job ID: 1785006145906913280
• Last Price Increase: 2024-05-21
• Automatic offers:
• ahmedGaber93 | Reviewer | 102448681

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f67e599996d40e27

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[kaushiktd]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Phone number mention in edit comment shows @expensify.sms

What is the root cause of that problem?

When a phone number is submitted or tagged, the ReportUtils.buildOptimisticAddCommentReportAction function is called here, Within this function, the getParsedComment function is invoked. Afterwards, the addDomainToShortMention function is called. This function checks whether the provided number is valid or not and then appends the @expensify.sms domain to it. Finally, the updated information is formatted in Parse Format to Onyx.

function named getParsedComment that parses inserted text using the Expensify-Common repository.This function should replace a given string with @expensify.sms as shown in the test case here.

What changes do you think we should make in order to solve the problem?

You need to verify if the parsed message adheres to a valid phone number format. If it meets the criteria for a phone number, you should eliminate the @expensify.sms domain during editing. Please update the provided code accordingly here.

let message = parser.htmlToMarkdown(getActionHtml(reportAction));
const lastContentAfterAt = message.substring(message.lastIndexOf("@"));
if(lastContentAfterAt == CONST.SMS.DOMAIN) {
    const beforeLastAt = message.substring(0, message.lastIndexOf("@"));
    message = beforeLastAt;
}  

Report.saveReportActionDraft(reportID, reportAction, message);

Or, you need to update with expensify-common. If it replaces without @expensify.sms, it will update to optimistic data and will not be reproduced after the API request.

Video

https://app.screencastify.com/v3/watch/J0jFdmbffkxugYfgIxF2

[muttmuure]

@ahmedGaber93 proposal above to take a look at