[HOLD for payment 2024-06-05] [$250] iOS - Expense - Chat header appears after delay when opening expense report

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.70-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch New Expensify app
2. Submit two expenses to a user with no chat history
3. In 1:1 DM, tap on the expense preview

Expected Result:

Expense report header will appear instantly

Actual Result:

The report content is displayed first, then followed by the chat header

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6469112_1714669668576.RPReplay_Final1714668295.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011fdda098a71985a0
• Upwork Job ID: 1786406953110065152
• Last Price Increase: 2024-05-10
• Automatic offers:
• DylanDylann | Reviewer | 0
• bernhardoj | Contributor | 0

Issue Owner

Current Issue Owner: @puneetlath

[melvin-bot]

Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@puneetlath FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[puneetlath]

I'm not able to reproduce this on my iOS app.

[francoisl]

Can't repro either with Browserstack. I get a "Review required" violation on each expense, but that's unrelated, and violations are still in beta.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The money report header shows with a delay.

What is the root cause of that problem?

The money report header connects to several onyx data,

App/src/components/MoneyReportHeader.tsx

Lines 318 to 331 in 0f39e43

	export default withOnyx<MoneyReportHeaderProps, MoneyReportHeaderOnyxProps>({
	chatReport: {
	key: ({report}) => `${ONYXKEYS.COLLECTION.REPORT}${report.chatReportID}`,
	},
	nextStep: {
	key: ({report}) => `${ONYXKEYS.COLLECTION.NEXT_STEP}${report.reportID}`,
	},
	transactionThreadReport: {
	key: ({transactionThreadReportID}) => `${ONYXKEYS.COLLECTION.REPORT}${transactionThreadReportID}`,
	},
	session: {
	key: ONYXKEYS.SESSION,
	},
	})(MoneyReportHeader);

and if the data is not available yet, withOnyx will return null. In this case, nextStep data is not available yet.

This has the same root cause as #41397

This also happens in the transaction header and the one that's not available yet is shownHoldUseExplanation

App/src/components/MoneyRequestHeader.tsx

Lines 246 to 249 in 0f39e43

	shownHoldUseExplanation: {
	key: ONYXKEYS.NVP_HOLD_USE_EXPLAINED,
	initWithStoredValues: true,
	},

What changes do you think we should make in order to solve the problem?

Set an initial value of the missing data.

For the nextStep, we can set it to an empty object.

App/src/components/MoneyReportHeader.tsx

Lines 322 to 324 in 0f39e43

	nextStep: {
	key: ({report}) => `${ONYXKEYS.COLLECTION.NEXT_STEP}${report.reportID}`,
	},

For the shownHoldUseExplanation, we can set it to false.

App/src/components/MoneyRequestHeader.tsx

Lines 246 to 249 in 0f39e43

	shownHoldUseExplanation: {
	key: ONYXKEYS.NVP_HOLD_USE_EXPLAINED,
	initWithStoredValues: true,
	},

However, there is currently a bug in withOnyx where a falsey initial value is ignored. I previously fixed it here to fix #35906, but gets reverted because of some bugs that appear in the App where it expects the falsey initial value to not work. So, in the new PR, I use useOnyx hook instead that doesn't have this falsey initial value issue. So, we can do the same by using useOnyx here.

We can consider this as a migration issue from withOnyx to useOnyx