[HOLD for payment] "No results found" message is missing when there're no search results for New Chat/New Group/Main Search

[aman-atg]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to e.cash
2. Open Main Search / New Chat / New Group
3. Type random word so that there're no search results

Expected Result:

Actual Result:

Workaround:

Visual Issue

Platform:

• [:heavy_check_mark: ] Web
• [ ✔️ ] iOS
• [:heavy_check_mark: ] Android
• [:heavy_check_mark: ] Desktop App
• [:heavy_check_mark: ] Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @NicMendonca (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[aman-atg]

Proposal :

App/src/libs/OptionsListUtils.js

Lines 667 to 685 in 9b1ea35

	function getHeaderMessage(hasSelectableOptions, hasUserToInvite, searchValue, maxParticipantsReached = false) {
	if (maxParticipantsReached) {
	return translate(preferredLocale, 'messages.maxParticipantsReached');
	}
	if (searchValue && CONST.REGEX.DIGITS_AND_PLUS.test(searchValue) && !Str.isValidPhone(searchValue)) {
	return translate(preferredLocale, 'messages.noPhoneNumber');
	}
	if (!hasSelectableOptions && !hasUserToInvite) {
	if (/^\d+$/.test(searchValue)) {
	return translate(preferredLocale, 'messages.noPhoneNumber');
	}
	return searchValue;
	}
	return '';
	}

• We're returning searchValue on line 681 instead of that we can use a different message like:
  • No results found
  • No users found
  • Please enter a valid email address
  • or any other message

[MelvinBot]

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Beamanator]

Thanks @aman-atg but this is technically working as expected. The search is waiting until you type a valid email address, then it will allow you to start a new chat with the email address you typed. We're working on some improvements in #2936 which should cover this case. When that solution gets merged, please feel free to test and let us know if it looks good or if you think it should change 👍 I'll close this for now.